Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Layer breaker in: vs/workbench/electron-browser/shell.ts #29079

Closed
bpasero opened this issue Jun 20, 2017 · 0 comments
Closed

Layer breaker in: vs/workbench/electron-browser/shell.ts #29079

bpasero opened this issue Jun 20, 2017 · 0 comments
Assignees
@alexdima
Labels
debt Code quality issues
Milestone
June 2017

Comments

@bpasero
Copy link
Member

bpasero commented Jun 20, 2017 •
edited

There is a dependency to ITextMateService and MainProcessTextMateSyntax from vs/workbench/parts/codeEditor/....

vs/workbench/parts is like a contrib folder. It should be possible to bundle the workbench without any of those parts.

I suggest to move that service into the vs/workbench/services (= core services) scope thereby.

See https://github.com/Microsoft/vscode/wiki/Code-Organization#workbench-parts
@bpasero bpasero added the debt Code quality issues label Jun 20, 2017
@alexdima alexdima added this to the June 2017 milestone Jun 20, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@alexdima alexdima

Labels
debt Code quality issues
Projects
None yet
Milestone
June 2017
Development

No branches or pull requests
2 participants
@bpasero @alexdima