-
Notifications
You must be signed in to change notification settings - Fork 27.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Not localized #29098
Comments
Maybe the translations have not made it in yet? |
Strangely this works for TS and other extensions. I don't know what Git does different here. Could be a problem with the tool that extracts the strings. |
As far as I confirmed, the following is also no translated.(It's already in i18n folder)
Also, if you don’t mind, could you tell me how to debug the Code-OSS including the display language function? |
@EbXpJ6bp you can't since nls is a build time step to make dev time expierence easy. You can only debug this in a build version which you can produce using the gulp script |
@dbaeumer Thanks! |
Apparently the issue was that message bundles were loaded before nls configuration was happening, thus defaulting to English locale. https://github.com/Microsoft/vscode-nls indicates that
I fixed it for git, php, markdown and merge-conflict extensions. |
@Microsoft/vscode if you own any extension that is localized, please ensure that See ab3c945 for reference 🙂 |
@michelkaporin We're lucky extensions are built to CommonJS... AMD wouldn't make this easy. |
@joaomoreno yeah, we would have to redesign all our localization logic... |
@michelkaporin Should we replicate that change across all extensions or only for specific cases? |
@chrmarti across all that use |
@michelkaporin Thanks for looking into this. |
Steps to Reproduce:
localize
points (secondary modules, in /extensions) do not work.I guess they cannot get
nls.config(process.env.VSCODE_NLS_CONFIG)()
.Example:
extensions/git/src/main.ts (has nls.config)
extensions/git/src/commands.ts (not work)
And, It seems that some Extensions(such, merge-conflict) have no
nls.config
.The text was updated successfully, but these errors were encountered: