Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vscode-insiders stopped respecting typescript.tsdk setting #29101

Closed
normalser opened this issue Jun 20, 2017 · 4 comments
Closed

Vscode-insiders stopped respecting typescript.tsdk setting #29101

normalser opened this issue Jun 20, 2017 · 4 comments
Assignees
@sandy081 @mjbvz
Labels
bug Issue identified by VS Code Team member as probable bug settings-editor VS Code settings editor issues typescript Typescript support issues verified Verification succeeded
Milestone
June 2017

Comments

@normalser
Copy link

I have installed:
vscode-insiders Version 1.14.0-insider (1.14.0-insider) 0b44bcd79af6783dff3fd9db4a9869c6de83c7bc
and
vscode Version 1.13.1 (1.13.1) 379d2efb5539b09112c793d3d9a413017d736f89

They both have User setting containing "typescript.tsdk": "/Users/normalser/.nvm/versions/node/v6.11.0/lib/node_modules/typescript/lib",
and nothing in 'Workspace setting' (to cause the issue)

vscode works fine and picks up that version but vscode-insiders stopped using that value and is using built-in typescript (it worked before)

Here is screenshot from vscode:
image

Here is screenshot from vscode-insiders:
image
@normalser
Copy link
Author

Found older zip with insiders (3a6eda7) - commit from 21 days ago - and it is working fine there. Not exactly sure which version made it stopped working

@mjbvz
Copy link
Contributor

mjbvz commented Jun 20, 2017 •
edited

@sandy081 Can you take look? It seems that workspace.getConfiguration().inspect('typescript.tsdk'); no longer returns any results. Inside of extHostConfiguration.ts, this.configuration.values() is empty in this case

@mjbvz mjbvz added settings-editor VS Code settings editor issues typescript Typescript support issues bug Issue identified by VS Code Team member as probable bug labels Jun 20, 2017
@sandy081 sandy081 added this to the June 2017 milestone Jun 21, 2017
@sandy081
Copy link
Member

Sure

@sandy081
Copy link
Member

This was caused by the adoption of settings for multi root. There was a refactoring done to use the common model in core and ext host. This model is missing keys being sent across the wire to ext host. Hence values are always undefined. Fixed it.

sandy081 added a commit that referenced this issue Jun 21, 2017
@sandy081
#29101 Tests for configuration inspect api
2120d0c
@roblourens roblourens added the verified Verification succeeded label Jun 29, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sandy081 sandy081

@mjbvz mjbvz

Labels
bug Issue identified by VS Code Team member as probable bug settings-editor VS Code settings editor issues typescript Typescript support issues verified Verification succeeded
Projects
None yet
Milestone
June 2017
Development

No branches or pull requests
4 participants
@roblourens @normalser @sandy081 @mjbvz