-
Notifications
You must be signed in to change notification settings - Fork 27.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Emmet 2.0: Insertion point is in wrong place after completion #29276
Comments
This is because the snippet returned by the emmet expand module in this case is @sergeche This is not the case in your emmet plugin. Is there anything extra that the plugin is doing? If so, shouldnt that be moved into the emmet module? |
The |
"Sequential" insertion points are missing too, such as when inserting two divs (e.g. |
@sergeche That's exactly what I am using https://github.com/ramya-rao-a/vscode-emmet-helper/blob/master/src/emmetHelper.ts#L118 The issue is not that none of the tab stops are being returned. For eg: |
The examples above works fine in Atom and unit-tests. Can you ensure that generated snippet doesn’t have expected tab stops? |
Ah! I found the issue Need to send Thanks @sergeche ! |
Fixed with microsoft/vscode-emmet-helper@cbef48c Thanks for reporting @smlombardi ! |
(4 theme extensions excluded)
Steps to Reproduce:
h1
<h1></h1>
as expected3.Except the cursor is after the completion, instead of inside the tag, so you can enter the text that goes in the
h1
as expected.The text was updated successfully, but these errors were encountered: