Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support themable active tab border #29333

Closed
teabyii opened this issue Jun 23, 2017 · 13 comments
Closed

Support themable active tab border #29333

teabyii opened this issue Jun 23, 2017 · 13 comments
Assignees
Labels
feature-request Request for new features or functionality themes Color theme issues verification-needed Verification of issue is requested verified Verification succeeded workbench-tabs VS Code editor tab issues
Milestone

Comments

@teabyii
Copy link

teabyii commented Jun 23, 2017

For examples:

image

and

image

@vscodebot vscodebot bot added the bug Issue identified by VS Code Team member as probable bug label Jun 23, 2017
@bpasero bpasero added feature-request Request for new features or functionality themes Color theme issues workbench and removed bug Issue identified by VS Code Team member as probable bug labels Jun 26, 2017
@adrianoresende
Copy link

Need to add options below:
tab.activeBorder.top/right/bottom/left
tab.border.top/right/bottom/left

@bpasero bpasero self-assigned this Aug 23, 2017
@bpasero bpasero added this to the August 2017 milestone Aug 23, 2017
@bpasero bpasero added the verification-needed Verification of issue is requested label Aug 23, 2017
@bpasero
Copy link
Member

bpasero commented Aug 23, 2017

Let's go with the border-bottom for now. I added:

  • tab.activeBorder
  • tab.unfocusedActiveBorder

image

@bpasero bpasero added the workbench-tabs VS Code editor tab issues label Aug 23, 2017
@adrianoresende
Copy link

Is only for color? and width?

@bpasero
Copy link
Member

bpasero commented Aug 23, 2017

@adrianoresende yes, we have no support for changing any elements dimensions, nor borders for theming in general.

@pahen
Copy link

pahen commented Aug 24, 2017

This is awesome @bpasero :) But it doesn't work on the Ayu themes. The bottom border isn't visible when I use tab.activeBorder. Could be related to the use of editorGroupHeader.tabsBorder in those themes. If I decrease the tab element to 34px instead of 35px I can see the border.

@bpasero
Copy link
Member

bpasero commented Aug 24, 2017

@pahen yeah I noticed this too, can you avoid using a border for the header? Having border for both tabs and header does not work currently. What is the intent of that border, I would assume it looks weird to have one border and then another one directly on top?

@pahen
Copy link

pahen commented Aug 24, 2017

I would like to keep that header border if possible to make it look as close to the original ST theme as possible. Like this: screen shot 2017-08-24 at 19 08 53

Yes, having the highlighted border above the header border will probably look weird.

@bpasero
Copy link
Member

bpasero commented Aug 24, 2017

@pahen this might be tough to accomplish due to the layering of elements but I will see what I can do. Can you file an issue?

@pahen
Copy link

pahen commented Aug 24, 2017

#33111 @bpasero

@bpasero
Copy link
Member

bpasero commented Aug 28, 2017

Verification:
Set the following new colors and ensure they work properly

  • tab.activeBorder
  • tab.unfocusedActiveBorder

@pahen
Copy link

pahen commented Aug 28, 2017

Works fine in the Ayu theme :)

screen shot 2017-08-28 at 19 57 37

@pahen
Copy link

pahen commented Aug 28, 2017

@bpasero This should probably be filed in another issue but it would be awesome if we could get rid of the default transparent border on every tab that causing the bottom border to have 1 pixel gap. Not sure of the intentions of that transparent border though.

See:
screen shot 2017-08-28 at 20 22 32

Setting the left and right border to none on that tab makes a pixel perfect bottom border:

screen shot 2017-08-28 at 20 23 10

screen shot 2017-08-28 at 20 21 16

@bpasero
Copy link
Member

bpasero commented Aug 29, 2017

@pahen that border is actually used to separate tabs from each other:

image

@jrieken jrieken added the verified Verification succeeded label Aug 29, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality themes Color theme issues verification-needed Verification of issue is requested verified Verification succeeded workbench-tabs VS Code editor tab issues
Projects
None yet
Development

No branches or pull requests

5 participants