Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trying to compile VS Code under Windows results in #29429

Closed
dbaeumer opened this issue Jun 26, 2017 · 2 comments
Closed

Trying to compile VS Code under Windows results in #29429

dbaeumer opened this issue Jun 26, 2017 · 2 comments
Assignees
@joaomoreno
Labels
bug Issue identified by VS Code Team member as probable bug javascript JavaScript support issues verified Verification succeeded
Milestone
June 2017

Comments

@dbaeumer
Copy link
Member 

P:\mseng\VSCode\vscode [master]> gulp --tasks-simple
module.js:598
  return process.dlopen(module, path._makeLong(filename));
                 ^

Error: The specified module could not be found.
\\?\P:\mseng\VSCode\vscode\node_modules\nsfw\build\Release\nsfw.node
    at Object.Module._extensions..node (module.js:598:18)
    at Module.load (module.js:488:32)
    at tryModuleLoad (module.js:447:12)
    at Function.Module._load (module.js:439:3)
    at Module.require (module.js:498:17)
    at require (internal/module.js:20:19)
    at Object.<anonymous> (P:\mseng\VSCode\vscode\node_modules\nsfw\lib\src\index.js:3:16)
    at Module._compile (module.js:571:32)
    at Object.Module._extensions..js (module.js:580:10)
    at Module.load (module.js:488:32)

This seems to be caused by the new nsfw module which we now use to compile vscode. Since we use that in gulp and not in vscode it should may be not compiled using the electron environment but the node environment.
@vscodebot vscodebot bot added bug Issue identified by VS Code Team member as probable bug javascript JavaScript support issues labels Jun 26, 2017
@dbaeumer dbaeumer added this to the June 2017 milestone Jun 26, 2017
@bpasero
Copy link
Member

bpasero commented Jun 26, 2017

Somehow the nsfw package is not being installed when running the root leveled scripts/npm.sh install

Will look into this with @joaomoreno. As a workaround you can set VSCODE_USE_LEGACY_WATCH=1

@bpasero bpasero assigned joaomoreno and unassigned bpasero Jun 26, 2017
@dbaeumer
Copy link
Member Author

Work now. Even the watcher after help from @bpasero

@dbaeumer dbaeumer added the verified Verification succeeded label Jun 29, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@joaomoreno joaomoreno

Labels
bug Issue identified by VS Code Team member as probable bug javascript JavaScript support issues verified Verification succeeded
Projects
None yet
Milestone
June 2017
Development

No branches or pull requests
4 participants
@joaomoreno @bpasero @dbaeumer @Tyriar