Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue a error if version 2.0.0 defines global OS specific tasks. #29446

Closed
dbaeumer opened this issue Jun 26, 2017 · 1 comment
Closed

Issue a error if version 2.0.0 defines global OS specific tasks. #29446

dbaeumer opened this issue Jun 26, 2017 · 1 comment
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug tasks Task system issues verified Verification succeeded
Milestone

Comments

@dbaeumer
Copy link
Member

This was never supported in 2.0.0 but a user might be hit when simply changing the version number. We should make this clear in the schema and issue an error message.

@vscodebot vscodebot bot added bug Issue identified by VS Code Team member as probable bug tasks Task system issues labels Jun 26, 2017
@dbaeumer dbaeumer self-assigned this Jun 26, 2017
@dbaeumer dbaeumer added this to the June 2017 milestone Jun 26, 2017
@dbaeumer
Copy link
Member Author

dbaeumer commented Jun 26, 2017

To verify: tasks.json

{
	// See https://go.microsoft.com/fwlink/?LinkId=733558
	// for the documentation about the tasks.json format
	"version": "2.0.0",
	"windows": {
		"tasks": [
			{
				"taskName": "mmm",
				"command": "echo"
			}
		]
	},
	"tasks": [
		{
			"type": "gulp",
			"task": "build",
			"problemMatcher": [
				"$tsc"
			],
			"group": { "kind": "build", "isPrimary": true },
			"presentation": {
				"echo": true,
				"reveal": "always",
				"focus": false,
				"panel": "dedicated"
			}
		}
	]
}

Should show an error under windows>tasks and an message in the output channel. If tested under different OS change windows to osx or linux

@michelkaporin michelkaporin added the verified Verification succeeded label Jun 30, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug tasks Task system issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

2 participants