History: files.exclude no longer applies #29520
Labels
bug
Issue identified by VS Code Team member as probable bug
file-explorer
Explorer widget issues
verified
Verification succeeded
Milestone
Steps to Reproduce:
=> the qunit folder should now hide from the explorer
=> bring up quick open and notice the file from qunit still showing up
This is unexpected, I have code that listens to changes to the
files.exclude
pattern and remove entries that no longer match. When I debug this I end up in this location right before I enterParsedExpression
here: https://github.com/Microsoft/vscode/blob/master/src/vs/workbench/services/history/browser/history.ts#L428The pattern does not match, but I verified that the setting is the one as defined. It gets created right here: https://github.com/Microsoft/vscode/blob/master/src/vs/workbench/services/history/browser/history.ts#L127
Is there something wrong with parsing maybe?
@chrmarti I have lost the ability to understand or even debug our glob implementation. Assigning to you in the hope that you have better ways of doing so. I think what we need is a way to log exactly how the matching happens within glob. Today this method is so heavily optimized and complex that I always loose myself in it.
The text was updated successfully, but these errors were encountered: