Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small exit button in diff review panel #29599

Closed
michelkaporin opened this issue Jun 27, 2017 · 1 comment
Closed

Small exit button in diff review panel #29599

michelkaporin opened this issue Jun 27, 2017 · 1 comment
Assignees
@alexdima
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone
June 2017

Comments

@michelkaporin
Copy link
Contributor

Testing #29496

In themes (incl. High Contrast theme) close button (cross in top right corner) is barely visible.

Maybe it's worth to make the quit-cross bigger if some people use high contrast together with screen reader?
@alexdima
Copy link
Member

The icon doesn't change with the dark theme, so that needs to be fixed, but the size is the same as the x button in other places, such as in the reference search (where I copied the button from), so I wouldn't mess with the size.

@alexdima alexdima added this to the June 2017 milestone Jun 27, 2017
@alexdima alexdima added the bug Issue identified by VS Code Team member as probable bug label Jun 28, 2017
@mjbvz mjbvz added the verified Verification succeeded label Jun 29, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@alexdima alexdima

Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Milestone
June 2017
Development

No branches or pull requests
3 participants
@michelkaporin @alexdima @mjbvz