Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restart task is not triggered from command and top level menu #29623

Closed
michelkaporin opened this issue Jun 27, 2017 · 2 comments
Closed

Restart task is not triggered from command and top level menu #29623

michelkaporin opened this issue Jun 27, 2017 · 2 comments
Assignees
@dbaeumer
Labels
bug Issue identified by VS Code Team member as probable bug tasks Task system issues verified Verification succeeded
Milestone
June 2017

Comments

@michelkaporin
Copy link
Contributor

Testing #29618.

  1. Clone https://github.com/Microsoft/vscode-languageserver-node and do npm install's
  2. Run the following task task tsc: build client\src\tsconfig.json through Task menu
  3. Once terminated, do 'Task -> Restart Task...' from menu.
    Observe that nothing happens.

Same happens if restart task is triggered from command palette. I assume this is because we moved tasks to a terminal by default.
@michelkaporin
Copy link
Contributor Author

It's interesting if I do the same but in jsonrpc subfolder, then 'Restart Task' works as a charm.

@dbaeumer dbaeumer added this to the June 2017 milestone Jun 27, 2017
@dbaeumer dbaeumer added tasks Task system issues bug Issue identified by VS Code Team member as probable bug labels Jun 27, 2017
@dbaeumer
Copy link
Member

@michaelchiche restart task terminates a running task and restarts it. I will add a message to say that no task is running if a user triggers the action. I will also rename it to Restart Running Task...

@sandy081 sandy081 added the verified Verification succeeded label Jun 29, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@dbaeumer dbaeumer

Labels
bug Issue identified by VS Code Team member as probable bug tasks Task system issues verified Verification succeeded
Projects
None yet
Milestone
June 2017
Development

No branches or pull requests
3 participants
@dbaeumer @michelkaporin @sandy081