Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use + and - as aria labels in the diff review panel #29741

Closed
alexdima opened this issue Jun 28, 2017 · 1 comment
Closed

Use + and - as aria labels in the diff review panel #29741

alexdima opened this issue Jun 28, 2017 · 1 comment
Assignees
@alexdima
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone
June 2017

Comments

@alexdima
Copy link
Member

Extracted from #29496 (comment)

  • what is currently read out as "unchanged" should be a no-op
  • what is currently read out as "inserted" should be "+"
  • what is currently read out as "deleted" should be "-"
@alexdima alexdima self-assigned this Jun 28, 2017
@alexdima alexdima added this to the June 2017 milestone Jun 28, 2017
@alexdima alexdima added the bug Issue identified by VS Code Team member as probable bug label Jun 28, 2017
@alexdima
Copy link
Member Author

@derekriemer I have just pushed the change to remove the words and substitute them with the signs. The change should be available in tormorrow's insiders.

FYI here are how the strings get built. Please let me know if you think I should tweak them further:

switch (type) {
	case DiffEntryType.Equal:
		ariaLabel = nls.localize('equalLine', "original {0}, modified {1}: {2}", originalLine, modifiedLine, lineContent);
		break;
	case DiffEntryType.Insert:
		ariaLabel = nls.localize('insertLine', "+ modified {0}: {1}", modifiedLine, lineContent);
		break;
	case DiffEntryType.Delete:
		ariaLabel = nls.localize('deleteLine', "- original {0}: {1}", originalLine, lineContent);
		break;
}

@jrieken jrieken added the verified Verification succeeded label Jun 29, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@alexdima alexdima

Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Milestone
June 2017
Development

No branches or pull requests
2 participants
@jrieken @alexdima