Pressing Enter leads to funny result #29755
Assignees
Labels
bug
Issue identified by VS Code Team member as probable bug
editor-autoindent
Editor auto indentation issues
verified
Verification succeeded
Milestone
Comments
|
This is really nasty. |
rebornix
added
bug
|
@rebornix Thank you for fixing. What I typically do for such simple repros is to always also write a test that captures the root cause, which fails at first and then make the necessary changes to make the test pass. This practice has saved me from regressing on multiple occasions and allows me to make changes with confidence. |
|
I was in a rush to fix quite a few issues but yes, tests ganruantee no
breaking changes. I'll add tests for all of them.
…On Wed, Jun 28, 2017 at 23:30 Alexandru Dima ***@***.***> wrote:
@rebornix <https://github.com/rebornix> Thank you for fixing.
What I typically do for such simple repros is to always also write a test
that captures the root cause, which fails at first and then make the
necessary changes to make the test pass.
This practice has saved me from regressing on multiple occasions and
allows me to make changes with confidence.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#29755 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AA1heEIxTi-g00Z5slZpyoE1LwK6zLDNks5sI0RmgaJpZM4OH8t0>
.
|
|
Nice! 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
The text was updated successfully, but these errors were encountered: