Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More Task API feedback #29759

Closed
jrieken opened this issue Jun 28, 2017 · 0 comments
Closed

More Task API feedback #29759

jrieken opened this issue Jun 28, 2017 · 0 comments
Assignees
Labels
tasks Task system issues
Milestone

Comments

@jrieken
Copy link
Member

jrieken commented Jun 28, 2017

Last round, I promise

  • I'd to rename RebuildAll to Rebuild, we also just call it Clean and Build
  • I'd add the [name:string]: any signature to TaskDefinition to make clear that there is more
  • I'd make Task#source not optional because it's also not optional in the ctor and since we want it in the UI
@vscodebot vscodebot bot added the tasks Task system issues label Jun 28, 2017
jrieken added a commit that referenced this issue Jun 28, 2017
@egamma egamma added this to the June 2017 milestone Jun 29, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
tasks Task system issues
Projects
None yet
Development

No branches or pull requests

3 participants