Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSON schema flags error although definition should be OK. #29848

Closed
dbaeumer opened this issue Jun 29, 2017 · 3 comments
Closed

JSON schema flags error although definition should be OK. #29848

dbaeumer opened this issue Jun 29, 2017 · 3 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug json JSON support issues verified Verification succeeded
Milestone

Comments

@dbaeumer
Copy link
Member

	oneOf: [
		{
			type: 'string',
		},
		{
			type: 'object',
			properties: {
				kind: {
					type: 'string',
					default: 'none',
					description: nls.localize('JsonSchema.tasks.group.kind', 'The task\'s execution group.')
				},
				isDefault: {
					type: 'boolean',
					default: false,
					description: nls.localize('JsonSchema.tasks.group.isDefault', 'Defines if this task is the default task in the group.')
				}
			}
		},
	],
	enum: [
		{ kind: 'build', isDefault: true },
		{ kind: 'build', isDefault: false },
		{ kind: 'test', isDefault: true },
		{ kind: 'test', isDefault: false },
		'build',
		'test',
		'none'
	],

A value like:

    "group": {
        "kind": "build",
        "isDefault": false
    }

Is flagged as false.

@vscodebot vscodebot bot added the tasks Task system issues label Jun 29, 2017
@dbaeumer dbaeumer added json JSON support issues and removed tasks Task system issues labels Jun 29, 2017
@dbaeumer dbaeumer added the bug Issue identified by VS Code Team member as probable bug label Jun 29, 2017
@aeschli aeschli added this to the June 2017 milestone Jun 29, 2017
aeschli added a commit that referenced this issue Jun 29, 2017
@dbaeumer
Copy link
Member Author

Thanks for fixing this so quickly

@joaomoreno
Copy link
Member

joaomoreno commented Jun 30, 2017

I'm still getting:

image

But maybe the change's not in yet?

@joaomoreno joaomoreno added the verified Verification succeeded label Jun 30, 2017
@joaomoreno
Copy link
Member

Verified, after git clean and npm i.

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug json JSON support issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

3 participants