Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: indentation detection incorrect when a block comment appears inside an argument list #29886

Closed
axefrog opened this issue Jun 29, 2017 · 1 comment
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug javascript JavaScript support issues verified Verification succeeded
Milestone

Comments

@axefrog
Copy link

axefrog commented Jun 29, 2017

  • VSCode Version: 1.14.0-insider
  • OS Version: Windows 10

This bug occurs in both JavaScript and TypeScript language modes.

Steps to Reproduce:

  1. Enter the following code:
function bar() {
  foo()
}

function foo() {
  bar(/*  */)
};
  1. Type a semicolon after foo() on line 2 - no problem
  2. Type a semicolon after bar(/* */) on line 6 - erroneous automatic unindentation
function bar() {
  foo();
}

function foo() {
bar(/*  */);
};
  1. Remove the block comment and try again - no problem
  2. Add a block comment inside the argument list on line 2 - erroneous automatic unindentation
function bar() {
foo(/*  */);
}

function foo() {
  bar();
};

Reproduces without extensions: Yes

@vscodebot vscodebot bot added insiders javascript JavaScript support issues labels Jun 29, 2017
@rebornix rebornix self-assigned this Jun 29, 2017
@mjbvz mjbvz self-assigned this Jun 29, 2017
@mjbvz mjbvz added this to the June 2017 milestone Jun 29, 2017
@mjbvz mjbvz added the bug Issue identified by VS Code Team member as probable bug label Jun 29, 2017
@mjbvz mjbvz closed this as completed in 7910b3d Jun 29, 2017
@isidorn isidorn added the verified Verification succeeded label Jun 30, 2017
@isidorn
Copy link
Contributor

isidorn commented Jun 30, 2017

I have verified this does not repro any more without any settings. If some settings need to be enabled for this broken behavior to happen please let me know. Note that editor.autoIndent is true by default

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug javascript JavaScript support issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

4 participants