Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a terminal.fontWeight setting #29887

Closed
DAddYE opened this issue Jun 29, 2017 · 16 comments
Closed

Add a terminal.fontWeight setting #29887

DAddYE opened this issue Jun 29, 2017 · 16 comments
Assignees
Labels
feature-request Request for new features or functionality help wanted Issues identified as good community contribution opportunities terminal Integrated terminal issues upstream Issue identified as 'upstream' component related (exists outside of VS Code)
Milestone

Comments

@DAddYE
Copy link

DAddYE commented Jun 29, 2017

  • VSCode Version: all
  • OS Version: osx

Steps to Reproduce:

  1. set "editor.fontWeight": "100"
  2. open the integrated terminal

The integrated terminal seems has no option for setting the fontWeight or at least follow the editor standard.

Thanks guys! Love vscode!

@vscodebot vscodebot bot added the terminal Integrated terminal issues label Jun 29, 2017
@Tyriar Tyriar changed the title Terminal font weight Add a terminal.fontWeight setting Jun 29, 2017
@Tyriar Tyriar added the feature-request Request for new features or functionality label Jun 29, 2017
@Tyriar Tyriar added this to the Backlog milestone Jun 29, 2017
@Tyriar Tyriar added good first issue Issues identified as good for first-time contributors help wanted Issues identified as good community contribution opportunities labels Jun 29, 2017
@brandontruggles
Copy link
Contributor

brandontruggles commented Jun 30, 2017

I would like to work on this!

EDIT:

This setting would conflict with the "terminal.integrated.enableBold" setting that currently exists. Should it override that setting if the font weight is set to bold or a higher weight?

@Tyriar
Copy link
Member

Tyriar commented Jun 30, 2017

@brandonrninefive @DAddYE do you think it makes sense to have a fontWeight but not a boldFontWeight? Can you think of an example font where it would make sense to have these setting(s)?

@brandontruggles
Copy link
Contributor

Hey @Tyriar, I feel that your idea of having both a "terminal.integrated.fontWeight" and a "terminal.integrated.boldFontWeight" would be best. Although I do not have a specific font example, I believe that this would provide the best user customization. For example, what if, for whatever reason, a user wanted to invert the default terminal font weights, and they wanted things such as folders to appear with the smaller weight, and then have normal files appear with the bolder weight? This would only be possible if both of these settings were to exist. The alternative would be to hardcode any terminal text displayed in a bold font weight to always have a slightly higher weight than specified in the "terminal.integrated.fontWeight" setting, but this would be very sloppy. For an example of the scenario I proposed above, picture the image below but with the white and blue font weights swapped.

image

@Tyriar
Copy link
Member

Tyriar commented Jul 5, 2017

Although I do not have a specific font example, I believe that this would provide the best user customization.

@brandonrninefive we tend to opt on the simplicity side of the spectrum to prevent bloat. I think we should hold off on this until there's a compelling case and multiple users that support it.

@Tyriar Tyriar removed good first issue Issues identified as good for first-time contributors help wanted Issues identified as good community contribution opportunities labels Jul 5, 2017
@dlchen
Copy link

dlchen commented Jul 11, 2017

I second this feature request! I use Source Code Pro ExtraLight (aka font-weight 200) in iTerm2 and would love to be able to set my integrated terminal to use the same font-weight. Thanks and keep up the great work!

@expenses
Copy link

I also support this. I would like to be able to use the same font weight in VS Code (below) as iTerm 2 (above).

code

@Tyriar
Copy link
Member

Tyriar commented Jul 17, 2017

@expenses can you not do this already using \x1b[1m in your $PS1 to bold ashley?

@expenses
Copy link

@Tyriar Ah, sorry, that wasn't a great example. What I want is the font to be bold for the whole term, not just the prompt.

@kext
Copy link

kext commented Jul 18, 2017

I would love this setting.

Currently I use Fira Code on Linux. I find the font a bit to light, however, so i have set "editor.fontWeight": "500". This does not change the terminal font weight though.

As a workaround I could set "terminal.integrated.fontFamily": "'Fira Code Medium'", but then "terminal.integrated.enableBold" no longer works.

So I support @brandonrninefive's proposal of adding "terminal.integrated.boldFontWeight" alongside "terminal.integrated.fontWeight" (and maybe "editor.boldFontWeight"?).

@Alek-S
Copy link

Alek-S commented Jul 21, 2017

I would be interested in this option as well. Specifically in my case to make the font thinner to be a closer match to what I have in iTerm, as the same font family seems a bit thicker in VSCode. Obviously, this would be more of a nice to have than a must have.

@ghost
Copy link

ghost commented Oct 16, 2017

@Tyriar this is must to have!!! 👍

@maliksahil
Copy link

I'd like to voice my support for this. This would be very nice to have.

@dangerdespain
Copy link

+1 would love to be able to squeeze more into the terminal pane without changing the font size across the app.

@Tyriar Tyriar added help wanted Issues identified as good community contribution opportunities upstream Issue identified as 'upstream' component related (exists outside of VS Code) labels Nov 7, 2017
@Tyriar
Copy link
Member

Tyriar commented Nov 7, 2017

I created the upstream issue that blocks this: xtermjs/xterm.js#1117, open to PRs

@Tyriar Tyriar closed this as completed in 8b3b72d Jan 23, 2018
@Tyriar
Copy link
Member

Tyriar commented Jan 23, 2018

@wyntau FYI the enableBold setting is being removed in favor of fontWeight and fontWeightBold in the next Insiders build. To disable bold you'll want to replace:

"terminal.integrated.enableBold": false

With:

"terminal.integrated.fontWeightBold": "normal"

@wyntau
Copy link

wyntau commented Jan 24, 2018

glad to hear that

@vscodebot vscodebot bot locked and limited conversation to collaborators Mar 9, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality help wanted Issues identified as good community contribution opportunities terminal Integrated terminal issues upstream Issue identified as 'upstream' component related (exists outside of VS Code)
Projects
None yet
Development

No branches or pull requests

10 participants