Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set emmet.useNewSetting to false by default in 1.14 #29908

Closed
ramya-rao-a opened this issue Jun 30, 2017 · 3 comments
Closed

Set emmet.useNewSetting to false by default in 1.14 #29908

ramya-rao-a opened this issue Jun 30, 2017 · 3 comments
Assignees
Labels
emmet Emmet related issues
Milestone

Comments

@ramya-rao-a
Copy link
Contributor

ramya-rao-a commented Jun 30, 2017

Currently in the Insiders we have emmet.useNewEmmet set to true by default.

Once the branch for release/1.14 is cut, this should be set to false in the release branch.

Creating this issue to track this, as I will be on vacation next week

https://github.com/Microsoft/vscode/blob/709211c2abfa7769431940e4f294bb4629076389/src/vs/workbench/parts/emmet/electron-browser/emmet.contribution.ts#L65

@vscodebot vscodebot bot added the emmet Emmet related issues label Jun 30, 2017
@ramya-rao-a ramya-rao-a assigned kieferrm and unassigned ramya-rao-a Jun 30, 2017
@ramya-rao-a ramya-rao-a added this to the June 2017 milestone Jun 30, 2017
@ta-riq
Copy link

ta-riq commented Jun 30, 2017

Can you please check the previous emmet issue (a few second ago) madam ramya rao ?

@ramya-rao-a
Copy link
Contributor Author

@ta-riq Can you link the other issue you are referring to?

@jens1o
Copy link
Contributor

jens1o commented Jun 30, 2017

He maybe means this issue #29907 @ramya-rao-a
Even though the reproduction steps are very poor.

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
emmet Emmet related issues
Projects
None yet
Development

No branches or pull requests

4 participants