Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Smoke test: Exclamation mark not typed and terminal not triggered #29940

Closed
egamma opened this issue Jun 30, 2017 · 1 comment
Closed

Smoke test: Exclamation mark not typed and terminal not triggered #29940

egamma opened this issue Jun 30, 2017 · 1 comment
Assignees
@michelkaporin
Labels
engineering VS Code - Build / issue tracking / etc.
Milestone
June 2017

Comments

@egamma
Copy link
Member

egamma commented Jun 30, 2017

image

Smoke Test Suite Data Loss verifies that contents of the dirty files are restored after 'hot exit'.zip

Smoke Test Suite Integrated Terminal opens terminal, runs 'echo' and verifies the output.zip
@egamma egamma added the engineering VS Code - Build / issue tracking / etc. label Jun 30, 2017
@michelkaporin
Copy link
Contributor

The reason for failures is the same as in #27841.

In first failure webdriver failed to type exclamation mark, whereas in the second "Ctrl+`" keybinding failed to be triggered due to layout issues again.

As a solution to this I propose not to type exclamation mark character in the first test and fallback to Command Palette command in the second case.

@michelkaporin michelkaporin modified the milestones: July 2017, June 2017 Jun 30, 2017
@michelkaporin michelkaporin changed the title Smoke test failures Smoke test: Exclamation mark not typed and terminal not triggered Jun 30, 2017
@michelkaporin michelkaporin mentioned this issue Jun 30, 2017
Closed
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2017
lemanschik pushed a commit to code-oss-dev/code that referenced this issue Nov 25, 2022
@michelkaporin
Fixes microsoft#29940
066c508
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@michelkaporin michelkaporin

Labels
engineering VS Code - Build / issue tracking / etc.
Projects
None yet
Milestone
June 2017
Development

No branches or pull requests
2 participants
@egamma @michelkaporin