Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fonts with plus sign in their names won't render. #30347

Closed
serkanyersen opened this issue Jul 10, 2017 · 2 comments
Closed

fonts with plus sign in their names won't render. #30347

serkanyersen opened this issue Jul 10, 2017 · 2 comments
Assignees
@alexdima
Labels
bug Issue identified by VS Code Team member as probable bug editor-rendering Editor rendering issues verified Verification succeeded
Milestone
April 2018

Comments

@serkanyersen
Copy link

  • VSCode Version: 1.13.1
  • OS Version: macos 10.12.5

Steps to Reproduce:

  1. Install this patched font from here https://github.com/gabrielelana/awesome-terminal-fonts/blob/patching-strategy/patched/SourceCodePro%2BPowerline%2BAwesome%2BRegular.ttf
  2. this font's name is SourceCodePro+Powerline+AwesomeRegular go to your settings.json and try to activate this font by setting the editor.fontFamily: "SourceCodePro+Powerline+AwesomeRegular"
  3. You'll see that step 2 will not work.
  4. now try setting the font like this
"editor.fontFamily": "\"SourceCodePro+Powerline+AwesomeRegular\"",

What's happening is that VSCODE won't put quotation marks around font name if there are no spaces in it. but this font name has plus signs in the name, chromium accepts that as space and won't render the font.

Reproduces without extensions: Yes
@vscodebot vscodebot bot added editor editor-core Editor basic functionality labels Jul 10, 2017
@rebornix rebornix added the bug Issue identified by VS Code Team member as probable bug label Aug 11, 2017
@alexdima alexdima self-assigned this Oct 26, 2017
@alexdima alexdima added font-rendering Font rendering issues and removed editor editor-core Editor basic functionality labels Apr 18, 2018
@alexdima
Copy link
Member

@serkanyersen I believe this has been fixed in the meantime with one of our Electron updates. i.e. I cannot reproduce anymore on the Insiders Build (https://code.visualstudio.com/insiders/):

kapture 2018-04-18 at 21 02 41

@alexdima
Copy link
Member

I can reproduce after reloading the window

@alexdima alexdima reopened this Apr 18, 2018
@alexdima alexdima added editor-rendering Editor rendering issues and removed font-rendering Font rendering issues labels Apr 18, 2018
@alexdima alexdima added this to the April 2018 milestone Apr 18, 2018
@tsalinger tsalinger added the verified Verification succeeded label Apr 26, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Jun 2, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@alexdima alexdima

Labels
bug Issue identified by VS Code Team member as probable bug editor-rendering Editor rendering issues verified Verification succeeded
Projects
None yet
Milestone
April 2018
Development

No branches or pull requests
4 participants
@serkanyersen @rebornix @alexdima @tsalinger