Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keyboard Shortcut to Skip Preview Using Quick Open #30530

Closed
mikeseese opened this issue Jul 12, 2017 · 8 comments
Closed

Keyboard Shortcut to Skip Preview Using Quick Open #30530

mikeseese opened this issue Jul 12, 2017 · 8 comments
Assignees
@bpasero
Labels
feature-request Request for new features or functionality quick-pick Quick-pick widget issues verification-needed Verification of issue is requested verified Verification succeeded
Milestone
November 2017

Comments

@mikeseese
Copy link
Contributor

I almost always use Quick Open (Ctrl/Command + P) to open my files. Sometimes I want to open multiple files, but they open in Preview by default when using the Quick Open.

I know that there is a user setting that allows you to disable Preview, but 85% of the time I enjoy the Preview.

This is a feature request to add a keyboard shortcut to open the selected file in Quick Open and skip Preview mode. The default behavior on Enter should still open it in Preview mode.

  • VSCode Version: 1.14.0
  • OS Version: Windows 10/elementary OS

Steps to Reproduce:

  1. Open "Quick Open" view using Ctrl (or Command) + P
  2. Type in a name
  3. Press Enter
  4. Verify that files is open in Preview mode
@vscodebot vscodebot bot added markdown Markdown support issues new release labels Jul 12, 2017
@Kampfmoehre
Copy link

+1 I would also like to see this feature implemented.

@chrmarti
Copy link
Contributor

You could use Keep Editor bound to Ctrl+K Enter (Cmd+K Enter on Mac) on the open editor.

@chrmarti chrmarti removed the markdown Markdown support issues label Jul 12, 2017
@mikeseese
Copy link
Contributor Author

I'll use that in the meantime while this gets implemented. Thanks for the tip!

@bpasero
Copy link
Member

bpasero commented Jul 12, 2017

Yeah I do agree that quick open is missing a way to open an entry in pinned mode, similar to how double clicking in the explorer will pin a file.

@bpasero bpasero added the quick-pick Quick-pick widget issues label Jul 12, 2017
@bpasero bpasero removed their assignment Jul 12, 2017
@chrmarti chrmarti added the feature-request Request for new features or functionality label Jul 12, 2017
@yfdyh000 yfdyh000 mentioned this issue Jul 20, 2017
Closed
@bpasero bpasero removed the workbench label Nov 16, 2017
This was referenced Nov 17, 2017
Closed
Closed
@bpasero bpasero changed the title Feature: Keyboard Shortcut to Skip Preview Using Quick Open Keyboard Shortcut to Skip Preview Using Quick Open Nov 17, 2017
@bpasero bpasero added this to the November 2017 milestone Nov 22, 2017
@bpasero bpasero self-assigned this Nov 22, 2017
@bpasero
Copy link
Member

bpasero commented Nov 22, 2017

Settled on Alt+Enter.

@cleidigh
Copy link
Contributor

@bpasero
Great! I've been wanting this command, have had to use 'Space' then Undo as touch.
Any reason not to add to explorer, file search, git?
If you agree I will do an issue and PR.

@bpasero
Copy link
Member

bpasero commented Nov 24, 2017

@cleidigh let me look into that, it should be done on a layer where every tree benefits from this...

@bpasero bpasero mentioned this issue Nov 24, 2017
Closed
@bpasero
Copy link
Member

bpasero commented Nov 24, 2017

I extracted #39101 for that purpose.

@cleidigh cleidigh mentioned this issue Nov 24, 2017
Closed
@bpasero bpasero added the verification-needed Verification of issue is requested label Nov 25, 2017
@dbaeumer dbaeumer added the verified Verification succeeded label Dec 5, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Jan 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bpasero bpasero

Labels
feature-request Request for new features or functionality quick-pick Quick-pick widget issues verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Milestone
November 2017
Development

No branches or pull requests
6 participants
@mikeseese @bpasero @dbaeumer @chrmarti @Kampfmoehre @cleidigh