Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Status title is appended to status message #30672

Closed
aeschli opened this issue Jul 14, 2017 · 4 comments
Closed

Status title is appended to status message #30672

aeschli opened this issue Jul 14, 2017 · 4 comments
Assignees
@aeschli
Labels
api bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone
August 2017

Comments

@aeschli
Copy link
Contributor

aeschli commented Jul 14, 2017

In the Java extension, we use the `window.withProgress' API with a title(in ProgressOptions) and messages.

When rendered the label that is shown is messages followed by title.
That's a bit strange and only works well if the message is just a percentage. If it also contains text, appending the title looks wrong.
@vscodebot vscodebot bot added the api label Jul 14, 2017
@aeschli aeschli mentioned this issue Jul 14, 2017
Merged
@jrieken jrieken added the bug Issue identified by VS Code Team member as probable bug label Jul 14, 2017
@jrieken jrieken added this to the July 2017 milestone Jul 17, 2017
@jrieken
Copy link
Member

jrieken commented Jul 17, 2017

@aeschli What is your suggestions? Where should the title go?

@aeschli
Copy link
Contributor Author

aeschli commented Jul 17, 2017

Intuitively, I'd say 'title' before 'message'. But I understand that some users put the percentage in the message. So maybe the API should include a percentage field. (I know I once recommend to remove it as it wasn't used at the time). Or the title just shows up as a tooltip on the wheel or when there is no message.

@jrieken jrieken assigned aeschli and unassigned jrieken Jul 24, 2017
@jrieken jrieken removed this from the July 2017 milestone Jul 24, 2017
@jrieken
Copy link
Member

jrieken commented Jul 24, 2017

@aeschli Feel free to do whatever change is needed. I am not really a consumer of that UX and don't know well enough what is needed. Now that we have a good and rich usage, I suggest to make it work for that and see what feedback we get

@aeschli aeschli added this to the August 2017 milestone Aug 10, 2017
@aeschli
Copy link
Contributor Author

aeschli commented Aug 10, 2017 •
edited

I made a change that the title is only used when there is no message. It is also used for the tooltip header.

@roblourens roblourens added the verified Verification succeeded label Aug 30, 2017
@Xanewok Xanewok mentioned this issue Oct 11, 2017
Merged
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@aeschli aeschli

Labels
api bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Milestone
August 2017
Development

No branches or pull requests
3 participants
@roblourens @jrieken @aeschli