Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Full path in debug callstack #30686

Closed
weinand opened this issue Jul 14, 2017 · 8 comments
Closed

Full path in debug callstack #30686

weinand opened this issue Jul 14, 2017 · 8 comments
Assignees
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues feature-request Request for new features or functionality release-notes Release notes issues verification-needed Verification of issue is requested verified Verification succeeded
Milestone

Comments

@weinand
Copy link
Contributor

weinand commented Jul 14, 2017

From @ubershmekel on June 5, 2017 21:18

I have an app with index.js that's calling my library that has an entry point of index.js which relies on node_modules/express/lib/router/index.js so my stack trace is entirely index.js with no way of telling which part of it is actually in my code.

Is there a way to give a user-configurable option or perhaps expand the path when there's room for it?

index.js

Related to:

Copied from original issue: microsoft/vscode-node-debug#146

@weinand
Copy link
Contributor Author

weinand commented Jul 14, 2017

You can hover over the name to see the full path of the name.

@vscodebot vscodebot bot added the debug Debug viewlet, configurations, breakpoints, adapter issues label Jul 14, 2017
@weinand weinand assigned isidorn and unassigned weinand Jul 14, 2017
@weinand weinand added the feature-request Request for new features or functionality label Jul 14, 2017
@ubershmekel
Copy link

@weinand thank you.

@auchenberg
Copy link
Contributor

Could we render the full path and simple use right-aligned text ellipsis to mask the overflow?

@isidorn
Copy link
Contributor

isidorn commented Jul 18, 2017

Thanks for the suggestions however rendering the full path would give more details to an already clutterd UI imho.
Though these sketches are a good first start for a PR.

@isidorn isidorn added this to the Backlog milestone Jul 18, 2017
@isidorn isidorn removed their assignment Jul 18, 2017
@weinand weinand modified the milestones: Backlog, On Deck Nov 14, 2017
@weinand
Copy link
Contributor Author

weinand commented Nov 14, 2017

To avoid the clutter when always showing the full path we could only show those segments from the end of the path that allow to distinguish files with the same name, e.g. something like this:

foo.js
src/index.js
router/index.js
main.js

With this approach most callstacks will continue to look compact and only those with duplicate file names will need more space.

@isidorn
Copy link
Contributor

isidorn commented Nov 14, 2017

I like this idea, it goes well with some other places in the workbench where in tabs we show path of a file only if the file name is duplicated.

@weinand
Copy link
Contributor Author

weinand commented Nov 14, 2017

Oh, I didn't know that. So even better!

@isidorn
Copy link
Contributor

isidorn commented May 11, 2018

We now show the path segments which distinguish the sources. You can try it in tomorrow's insiders

screen shot 2018-05-11 at 15 16 42

@isidorn isidorn modified the milestones: On Deck, May 2018 May 11, 2018
@isidorn isidorn added the verification-needed Verification of issue is requested label May 11, 2018
roblourens referenced this issue May 14, 2018
@roblourens roblourens added the verified Verification succeeded label May 30, 2018
@isidorn isidorn added the release-notes Release notes issues label Jun 1, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Jun 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues feature-request Request for new features or functionality release-notes Release notes issues verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

5 participants