Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[folding] unfolding selected groups of folded code issue #31446

Closed
abdhass opened this issue Jul 26, 2017 · 1 comment
Closed

[folding] unfolding selected groups of folded code issue #31446

abdhass opened this issue Jul 26, 2017 · 1 comment
Assignees
@aeschli
Labels
bug Issue identified by VS Code Team member as probable bug editor-folding Editor code folding issues verified Verification succeeded
Milestone
August 2017

Comments

@abdhass
Copy link

abdhass commented Jul 26, 2017

  • VSCode Version: Code 1.14.2 (cb82feb, 2017-07-19T23:34:09.706Z)
  • OS Version: Windows_NT ia32 6.1.7601
  • Extensions:
Extension Author (truncated) Version
html-class-suggestions And 1.0.7
vscode-eslint dba 1.2.11
vscode-html-css ecm 0.1.7
sublime-babel-vscode jos 0.2.6
format-php Kas 1.1.2
vscode-JS-CSS-HTML-formatter lon 0.2.3
debugger-for-chrome msj 3.1.6
laravel-blade one 1.8.1
laravel5-snippets one 1.3.4

(1 theme extensions excluded)

Steps to Reproduce:

  1. fold two divs of code
<div>
  <h1></h1>
</div>
<div>
  <h1></h1>
</div>
  1. Highlight both folded divs.
  2. unfold the second div
  3. Notice how the highlighted region starts at end of first row

Reproduces without extensions: Yes

Step 1:
image

Step 2:
image

Step 3:
image
@aeschli aeschli assigned alexdima and unassigned aeschli Aug 2, 2017
@alexdima
Copy link
Member

@aeschli The call that changes the selection in the editor comes from FoldingController:

When expanding the second fold region:

Error
    at Cursor.setSelections (file:///Users/alex/src/vscode/out/vs/editor/common/controller/cursor.js:248:37)
    at CodeEditor.CommonCodeEditor.setSelections (file:///Users/alex/src/vscode/out/vs/editor/common/commonCodeEditor.js:330:25)
    at FoldingController.updateHiddenAreas (file:///Users/alex/src/vscode/out/vs/editor/contrib/folding/browser/folding.js:331:29)
    at file:///Users/alex/src/vscode/out/vs/editor/contrib/folding/browser/folding.js:301:35
    at Model.TextModelWithDecorations._changeDecorations (file:///Users/alex/src/vscode/out/vs/editor/common/model/textModelWithDecorations.js:173:26)
    at Model.TextModelWithDecorations.changeDecorations (file:///Users/alex/src/vscode/out/vs/editor/common/model/textModelWithDecorations.js:145:29)
    at CodeEditor.CommonCodeEditor.changeDecorations (file:///Users/alex/src/vscode/out/vs/editor/common/commonCodeEditor.js:556:31)
    at FoldingController.onEditorMouseUp (file:///Users/alex/src/vscode/out/vs/editor/contrib/folding/browser/folding.js:294:25)
    at file:///Users/alex/src/vscode/out/vs/editor/contrib/folding/browser/folding.js:198:88
    at CallbackList.invoke (file:///Users/alex/src/vscode/out/vs/base/common/callbackList.js:58:43)"

@alexdima alexdima assigned aeschli and unassigned alexdima Aug 10, 2017
@aeschli aeschli mentioned this issue Aug 10, 2017
Closed
@aeschli aeschli added this to the August 2017 milestone Aug 11, 2017
@aeschli aeschli added editor-folding Editor code folding issues bug Issue identified by VS Code Team member as probable bug labels Aug 11, 2017
@aeschli aeschli changed the title unfolding selected groups of folded code issue [folding] unfolding selected groups of folded code issue Aug 11, 2017
@aeschli aeschli mentioned this issue Aug 12, 2017
Closed
@roblourens roblourens added the verified Verification succeeded label Aug 31, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@aeschli aeschli

Labels
bug Issue identified by VS Code Team member as probable bug editor-folding Editor code folding issues verified Verification succeeded
Projects
None yet
Milestone
August 2017
Development

No branches or pull requests
5 participants
@roblourens @alexdima @aeschli @abdhass @chrmarti