Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Files: Compare Active File with... - Exclude selected file from picklist #31853

Closed
cleidigh opened this issue Aug 1, 2017 · 1 comment · Fixed by #32803
Closed

Files: Compare Active File with... - Exclude selected file from picklist #31853

cleidigh opened this issue Aug 1, 2017 · 1 comment · Fixed by #32803
Assignees
@bpasero
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone
August 2017

Comments

@cleidigh
Copy link
Contributor

cleidigh commented Aug 1, 2017

Code 1.14.2

Since it does not make sense and Code prevents comparing a file with itself,
it would make sense to exclude the current file from the file picklist for comparing files.
@vscodebot vscodebot bot added the workbench label Aug 1, 2017
@kieferrm kieferrm added the feature-request Request for new features or functionality label Aug 1, 2017
@cleidigh cleidigh mentioned this issue Aug 18, 2017
Merged
@cleidigh
Copy link
Contributor Author

@kieferrm

Fixed with PR #32803

@bpasero bpasero self-assigned this Aug 21, 2017
@bpasero bpasero added this to the August 2017 milestone Aug 21, 2017
@bpasero bpasero added bug Issue identified by VS Code Team member as probable bug and removed feature-request Request for new features or functionality labels Aug 21, 2017
bpasero pushed a commit that referenced this issue Aug 21, 2017
@cleidigh @bpasero
Bug: Exclude active file from compare list (Cannot compare with self) F…
3cf182b 
…ixes: #31853 (#32803)

* Exclude active file from compare list

* Use preferred toString to compare resources
@jrieken jrieken added the verified Verification succeeded label Aug 30, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bpasero bpasero

Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Milestone
August 2017
Development

Successfully merging a pull request may close this issue.

Bug: Exclude active file from compare list (Cannot compare with self) Fixes: #31853 cleidigh/vscode
4 participants
@bpasero @jrieken @kieferrm @cleidigh