Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flicker in keybindings editor on every keystroke #32099

Closed
kieferrm opened this issue Aug 7, 2017 · 1 comment
Closed

Flicker in keybindings editor on every keystroke #32099

kieferrm opened this issue Aug 7, 2017 · 1 comment
Assignees
@alexdima
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone
August 2017

Comments

@kieferrm
Copy link
Member

kieferrm commented Aug 7, 2017

  • VSCode Version: Code - Insiders 1.15.0-insider (6feff11, 2017-08-04T17:43:56.658Z)
  • OS Version: Darwin x64 16.7.0
  • Extensions:
Extension Author (truncated) Version
vscode-docker Pet 0.0.16
quokka-vscode Wal 1.0.46
crazy kie 0.0.1
githistory don 0.2.2
python don 0.7.0
gitlens eam 4.3.3
tslint eg2 0.17.0
vscode-npm-script eg2 0.2.0
vsc-travis-ci-status fel 1.1.0
svgpreview kis 0.2.0
Go luk 0.6.63
mssql ms- 1.1.0
github-issues-prs ms- 0.4.0
debugger-for-chrome msj 3.1.7
vscode-versionlens pfl 0.19.1
Ruby reb 0.13.0
kustovscode sea 0.0.1
php-syntax-visualizer vsc 0.0.1
vscode-open-in-github ziy 1.2.7

(1 theme extensions excluded)

Steps to Reproduce:

  1. Open the json based keyboard shortcut editor
  2. On the right paste the following:
[
    {
        "key": "cmd+k",
        "command": "workbench.action.terminal.clear",
        "when": "ter"
    }
]
  1. type a character within the when clause
    -> the left side is re-colorized resulting in a flashing editor and minimap

This is a regression.
@kieferrm kieferrm added the bug Issue identified by VS Code Team member as probable bug label Aug 7, 2017
@vscodebot vscodebot bot added the insiders label Aug 7, 2017
@alexdima
Copy link
Member

alexdima commented Aug 8, 2017

I can reproduce in 1.14.2, so I don't believe this is a regression introduced in the 1.15 timeframe.

I would suggest we ship 1.15 with this bug.

kapture 2017-08-08 at 11 25 40

@alexdima alexdima added this to the August 2017 milestone Aug 8, 2017
@bpasero bpasero added the verified Verification succeeded label Aug 30, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@alexdima alexdima

Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Milestone
August 2017
Development

No branches or pull requests
3 participants
@bpasero @kieferrm @alexdima