Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Emmet for Yandex BEM support in JSX #32183

Closed
yujiaze opened this issue Aug 9, 2017 · 3 comments
Closed

Emmet for Yandex BEM support in JSX #32183

yujiaze opened this issue Aug 9, 2017 · 3 comments
Assignees
@ramya-rao-a
Labels
bug Issue identified by VS Code Team member as probable bug emmet Emmet related issues verified Verification succeeded
Milestone
August 2017

Comments

@yujiaze
Copy link

yujiaze commented Aug 9, 2017

  • VSCode Version: 1.14.2
  • OS Version: 10.12.5

Steps to Reproduce:

  1. typein .b_m1._m2|bem in a React Component render function
  2. press tab
  3. got <div className="b_m1 _m2"></div>
  4. expected <div className="b b_m1 b_m2"></div>

Reproduces without extensions: Yes

FYI：Yandex BEM
@vscodebot vscodebot bot added the emmet Emmet related issues label Aug 9, 2017
@mrmlnc
Copy link
Contributor

mrmlnc commented Aug 9, 2017 •
edited

Hello, @yujiaze,

You use the original Emmet or Emmet with emmet.useNewEmmet: true option? This behavior reproduce with HTML syntax or it related only to JS/TS (React)?

@ramya-rao-a
Copy link
Contributor

Looks like the bem filter never worked for in jsx in VS Code.

@ramya-rao-a ramya-rao-a added the bug Issue identified by VS Code Team member as probable bug label Aug 9, 2017
@ramya-rao-a ramya-rao-a added this to the August 2017 milestone Aug 9, 2017
@ramya-rao-a
Copy link
Contributor

ramya-rao-a commented Aug 9, 2017 •
edited

Thanks for reporting @yujiaze

Bem for jsx never worked before VS Code 1.15

In VS code 1.15, there is a broken experience for bem in jsx, its fine in html
Its too late in the game to push a fix for 1.15... We are just about to release 1.15

So I have fixed it for VS Code 1.16 and you should be able to see the fix in 1.16 insiders next week.

If there ever is a recovery build for 1.15, I'll try and get this in for 1.15.1

@mjbvz mjbvz added the verified Verification succeeded label Aug 31, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ramya-rao-a ramya-rao-a

Labels
bug Issue identified by VS Code Team member as probable bug emmet Emmet related issues verified Verification succeeded
Projects
None yet
Milestone
August 2017
Development

No branches or pull requests
4 participants
@mrmlnc @mjbvz @yujiaze @ramya-rao-a