Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New emmet doesn't work in sass files #32281

Closed
ramya-rao-a opened this issue Aug 11, 2017 · 4 comments
Closed

New emmet doesn't work in sass files #32281

ramya-rao-a opened this issue Aug 11, 2017 · 4 comments
Assignees
@ramya-rao-a
Labels
bug Issue identified by VS Code Team member as probable bug emmet Emmet related issues verified Verification succeeded
Milestone
August 2017

Comments

@ramya-rao-a
Copy link
Contributor

Emmet works as expected in css,less,scss files, but not sass files.

Root cause:

https://github.com/emmetio/css-parser is used to parse the file.
For sass files, this doesn't work and the current node turns out to be null which gets invalidated at https://github.com/Microsoft/vscode/blob/release/1.15/extensions/emmet/src/abbreviationActions.ts#L161
@vscodebot vscodebot bot added the emmet Emmet related issues label Aug 11, 2017
ramya-rao-a added a commit that referenced this issue Aug 11, 2017
@ramya-rao-a
Remove validation based on location for sass file #32281
90b6859
@ramya-rao-a
Copy link
Contributor Author

Until there is module that supports parsing sass files, we can skip the check based on cursor location for sass files

@ramya-rao-a ramya-rao-a added the bug Issue identified by VS Code Team member as probable bug label Aug 11, 2017
@ramya-rao-a ramya-rao-a added this to the August 2017 milestone Aug 11, 2017
ramya-rao-a added a commit that referenced this issue Aug 14, 2017
@ramya-rao-a
Remove validation based on location for sass file #32281
1be09af
@roblourens
Copy link
Member

Verified that emmet doesn't show up for sass files, if that's the right thing to check.

@roblourens roblourens added the verified Verification succeeded label Aug 31, 2017
@ramya-rao-a
Copy link
Contributor Author

@roblourens

You need the Sass extension for VS Code to identify the sass file type
https://marketplace.visualstudio.com/items?itemName=robinbentley.sass-indented

Once that is installed, you can then use emmet

@roblourens
Copy link
Member

I see, I thought this was removing emmet support. I verify that it works with the extension installed.

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ramya-rao-a ramya-rao-a

Labels
bug Issue identified by VS Code Team member as probable bug emmet Emmet related issues verified Verification succeeded
Projects
None yet
Milestone
August 2017
Development

No branches or pull requests
2 participants
@roblourens @ramya-rao-a