Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[json] hover over color box doesn't show color picker #32298

Closed
bpasero opened this issue Aug 11, 2017 · 10 comments
Closed

[json] hover over color box doesn't show color picker #32298

bpasero opened this issue Aug 11, 2017 · 10 comments
Assignees
Milestone

Comments

@bpasero
Copy link
Member

bpasero commented Aug 11, 2017

It seems I am not presented with the color picker when I hover over colors inside settings (e.g. workbench.colorCustomizations).

image

@aeschli
Copy link
Contributor

aeschli commented Aug 11, 2017

Are you on the final 1.15 or latest insiders?
image

@aeschli aeschli closed this as completed Aug 11, 2017
@bpasero
Copy link
Member Author

bpasero commented Aug 11, 2017

@aeschli this is running from sources, I do not see this hover.

@bpasero bpasero reopened this Aug 11, 2017
@bpasero
Copy link
Member Author

bpasero commented Aug 11, 2017

panel-red

Looks like an exception is logged:

Illegal argument: range: Error: Illegal argument: range
    at Object.illegalArgument (/Users/bpasero/Development/Microsoft/monaco/out/vs/base/common/errors.js:161:20)
    at new ColorInfo (/Users/bpasero/Development/Microsoft/monaco/out/vs/workbench/api/node/extHostTypes.js:978:32)
    at ColorProvider.<anonymous> (/Users/bpasero/Development/Microsoft/monaco/extensions/json/client/out/colorDecorators.js:181:45)
    at step (/Users/bpasero/Development/Microsoft/monaco/extensions/json/client/out/colorDecorators.js:36:23)
    at Object.f [as next] (/Users/bpasero/Development/Microsoft/monaco/extensions/json/client/out/colorDecorators.js:17:53)
    at fulfilled (/Users/bpasero/Development/Microsoft/monaco/extensions/json/client/out/colorDecorators.js:8:58)
    at process._tickCallback (internal/process/next_tick.js:103:7)

@aeschli
Copy link
Contributor

aeschli commented Aug 11, 2017

@bpasero Can you attach the full file content?

@bpasero
Copy link
Member Author

bpasero commented Aug 11, 2017

@aeschli here:

{
    "window.zoomLevel": 1,
    "files.autoSave": "off",
    "explorer.openEditors.visible": 9,
    "workbench.editor.enablePreview": false,
    "files.trimTrailingWhitespace": true,
    "files.insertFinalNewline": true,
    "debug.inlineValues": true,
    "git.confirmSync": false,
    "git.enableSmartCommit": true,
    "editor.minimap.enabled": false,
    "editor.renderIndentGuides": false,
    "editor.dragAndDrop": false,
    "search.quickOpen.includeSymbols": false,
    "workbench.startupEditor": "newUntitledFile",
    "window.restoreWindows": "all",
    "window.restoreFullscreen": true,
    "workbench.activityBar.visible": true,
    "workbench.colorCustomizations": {
        "statusBar.background": "#adadad"
    }
}

@aditp91
Copy link

aditp91 commented Aug 11, 2017

I'm not even able to get the hover on json files. It works on others like js, css, etc. Anyone else having this issue?

@aeschli
Copy link
Contributor

aeschli commented Aug 11, 2017

@bpasero Still can't reproduce, also not with your content. Can you enable:
"css.trace.server": "verbose" and see what ranges are returned for colors?
Or I'll debug it on your machine next week.

@bpasero
Copy link
Member Author

bpasero commented Aug 11, 2017

@aeschli I can reproduce even with a simple example of just opening the settings file directly (in this case a settings.json file within a workspace).

image

Not seeing any output, where should I look at?

Btw the exception could be a red herring, now I am not seeing the exception anymore but I still do not get the color picker.

@aeschli
Copy link
Contributor

aeschli commented Aug 11, 2017

@aditp91 Please file a separate issue...

@bpasero
Copy link
Member Author

bpasero commented Aug 11, 2017

@aeschli I know what is different, in JSON I need to hover over the value, I cannot hover over the color box. The hover works fine once I hover over the string value of the color.

@aeschli aeschli changed the title Settings: allow to use the color picker [json] hover over color box doesn't show color picker Aug 12, 2017
@aeschli aeschli added this to the August 2017 milestone Aug 12, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants