Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Color Picker: Colors lose precision #32323

Closed
joaomoreno opened this issue Aug 11, 2017 · 1 comment
Closed

Color Picker: Colors lose precision #32323

joaomoreno opened this issue Aug 11, 2017 · 1 comment
Assignees
@rebornix
Labels
bug Issue identified by VS Code Team member as probable bug editor-color-picker Editor color picker widget issues
Milestone
Backlog

Comments

@joaomoreno
Copy link
Member

Have this CSS:

body {
    color: hsla(121, 45%, 29%, 0.61);
}

If you hover over that color, you'll notice the ColorPicker fails to recognize the format and shows hex instead, because the way to color is passed around (to RGB and back to HSL), precision is lost and the new format would be hsla(121, 45%, 28%, 0.61).
@joaomoreno joaomoreno added bug Issue identified by VS Code Team member as probable bug editor-color-picker Editor color picker widget issues labels Aug 11, 2017
@joaomoreno joaomoreno added this to the Backlog milestone Aug 11, 2017
@joaomoreno joaomoreno self-assigned this Aug 11, 2017
@praveenpuglia
Copy link
Contributor

I was gonna report this now and found it. Also, it shows 8 and 4 digit hex colors which is still to be supported by browsers.

I guess the color picker should use the user authored format until they deliberately change it, either in code or via the color picker.

@joaomoreno joaomoreno assigned rebornix and unassigned joaomoreno Aug 14, 2017
rebornix added a commit that referenced this issue Aug 19, 2017
@rebornix
#32323, test case for formatter.
f90f8ae
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@rebornix rebornix

Labels
bug Issue identified by VS Code Team member as probable bug editor-color-picker Editor color picker widget issues
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
3 participants
@joaomoreno @praveenpuglia @rebornix