Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

terminal.integrated.rightClickCopyPaste isn't working on x64 build #32336

Closed
nborko opened this issue Aug 11, 2017 · 3 comments
Closed

terminal.integrated.rightClickCopyPaste isn't working on x64 build #32336

nborko opened this issue Aug 11, 2017 · 3 comments
Assignees
@Tyriar
Labels
bug Issue identified by VS Code Team member as probable bug terminal Integrated terminal issues verified Verification succeeded windows VS Code on Windows issues
Milestone
August 2017

Comments

@nborko
Copy link

nborko commented Aug 11, 2017

  • VSCode Version: Code 1.15.0 (8b95971, 2017-08-09T20:16:18.034Z)
  • OS Version: Windows_NT x64 10.0.15063
  • Extensions:
Extension Author (truncated) Version
html-snippets abu 0.1.0
vscode-css-formatter aes 0.0.2
swagger-viewer Arj 1.4.0
vscode-eslint dba 1.2.11
vscode-great-icons emm 2.1.14
vscode-tfs iva 0.6.0
sublime-babel-vscode jos 0.2.6
vscode-csscomb mrm 5.1.0
vscode-less mrm 0.6.3
csharp ms- 1.12.0
vetur oct 0.9.3
rewrap stk 1.4.2
highlight-trailing-white-spaces yba 0.0.2
ActionScript3 yop 0.0.1

(2 theme extensions excluded)

Steps to Reproduce:

  1. Enable terminal.integrated.rightClickCopyPaste (seems to be true by default)
  2. Select text and right click in the integrated terminal window. Context menu appears.

Reproduces without extensions: Yes
@vscodebot vscodebot bot added the terminal Integrated terminal issues label Aug 11, 2017
@markalexandercastillo
Copy link

Also running into this.

VSCode info:

Version 1.15.0
Commit 8b95971
Date 2017-08-09T20:09:15.006Z
Shell 1.6.6
Renderer 56.0.2924.87
Node 7.4.0
Architecture x64

Same reproduction steps as nborko

@Tyriar Tyriar added this to the August 2017 milestone Aug 16, 2017
@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug windows VS Code on Windows issues labels Aug 16, 2017
@Tyriar Tyriar mentioned this issue Aug 17, 2017
Closed
@ihalip
Copy link
Contributor

ihalip commented Aug 24, 2017

Repro'd this. It looks like the mousedown event (https://github.com/Microsoft/vscode/blob/master/src/vs/workbench/parts/terminal/electron-browser/terminalPanel.ts#L178) is not received when there is text selected in the terminal. It doesn't matter if you right-click inside or outside the selection.

@Tyriar
Copy link
Member

Tyriar commented Aug 24, 2017

Thanks for the tip @ihalip. Looks like this line is the problem:

https://github.com/sourcelair/xterm.js/blob/6e9d60d76d6cfb3d279f9e58499ba62ca6af479c/src/SelectionManager.ts#L319

@Tyriar Tyriar mentioned this issue Aug 24, 2017
Closed
Tyriar added a commit to Tyriar/xterm.js that referenced this issue Aug 24, 2017
@Tyriar
Build lib
39c35bc 
Brings in rightClickCopyPaste fix microsoft/vscode#32336
@Tyriar Tyriar closed this as completed in ac1fa34 Aug 24, 2017
@mjbvz mjbvz added the verified Verification succeeded label Sep 1, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

Labels
bug Issue identified by VS Code Team member as probable bug terminal Integrated terminal issues verified Verification succeeded windows VS Code on Windows issues
Projects
None yet
Milestone
August 2017
Development

No branches or pull requests
5 participants
@nborko @ihalip @markalexandercastillo @Tyriar @mjbvz