Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make snippet highlights themeable #32484

Closed
user3323 opened this issue Aug 14, 2017 · 5 comments
Closed

Make snippet highlights themeable #32484

user3323 opened this issue Aug 14, 2017 · 5 comments
Assignees
@jrieken
Labels
feature-request Request for new features or functionality release-notes Release notes issues snippets verification-needed Verification of issue is requested verified Verification succeeded
Milestone
September 2018

Comments

@user3323
Copy link

  • VSCode Version: 1.15
  • OS Version: win7x64

Can someone tell, what setting is responsible for highlighting the "next label" in the "snippet mode"?

Cause, for example, I have this snippet "setAttribute("${1:attr}", "${2:value}");$0"
but if you will look at the screenshot, I think you won't say that there is any highlighting on "value", it's extra faded.

image
@jrieken jrieken added snippets feature-request Request for new features or functionality labels Aug 15, 2017
@jrieken jrieken changed the title What setting is responsible for highlighting the "next label" in the "snippet mode"? Make snippet highlights themeable Aug 15, 2017
@jrieken jrieken mentioned this issue Jul 12, 2018
Closed
@jrieken jrieken added this to the September 2018 milestone Sep 17, 2018
@jrieken
Copy link
Member

jrieken commented Sep 17, 2018

This is now snippetPlaceholder.brackground and snippetFinalPlaceholder.border.

/cc @bpasero in his role as color name police

@bpasero
Copy link
Member

bpasero commented Sep 17, 2018

Sounds good to me, also @aeschli for editor-color name police

@bpasero
Copy link
Member

bpasero commented Sep 17, 2018 •
edited

@aeschli actually it seems to me many colors are in the editor. namespace, not sure what you rule is here:

image

editor.snippetPlaceholderBackground seems a bit long to me, but so far we have no snippet category top level for theme colors.

@aeschli
Copy link
Contributor

aeschli commented Sep 18, 2018

Definitely needs to be in the editor namespace. It's another highlight color, so I'd have that in the name too.

editor.snippetPlaceholderHighlightBackground
editor.snippetTabStopForeground

Maybe just call it
editor.snippetHighlightBackground ?

Normally the highlight colors also have a border variant, used in high contrast, but available for any theme.

@jrieken
Copy link
Member

jrieken commented Sep 18, 2018

ok, the colors are now

  • editor.snippetTabstopHighlightBackground
  • editor.snippetTabstopHighlightBorder
  • editor.snippetFinalTabstopHighlightBackground
  • editor.snippetFinalTabstopHighlightBorder

jrieken added a commit that referenced this issue Sep 18, 2018
@jrieken
fix snippet theme colors #32484
d9add55
@jrieken jrieken added the verification-needed Verification of issue is requested label Sep 24, 2018
@mjbvz mjbvz added the verified Verification succeeded label Sep 25, 2018
@jrieken jrieken added the release-notes Release notes issues label Sep 27, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 1, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jrieken jrieken

Labels
feature-request Request for new features or functionality release-notes Release notes issues snippets verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Milestone
September 2018
Development

No branches or pull requests
6 participants
@bpasero @jrieken @aeschli @chrmarti @mjbvz @user3323