Dropping a folder on Windows appears that it's handled as a file

The behavior is a little odd in the terminal as well, adding a / at the start:

Ah that's probably unrelated.

We could take this as an opportunity to improve the current behavior, especially since the new DataTransferItem behavior is to spec. Dragging a folder could just show the drop area of a file but handle the folder in multiple ways.

• Dropping a folder in the editor:
  • Open all files in the folder in this editor group?
  • Open the folder?
  • Add folder as workspace?
• Dropping a folder in the explorer:
  • Copy the folder into the location?
  • Open the folder?
  • Add folder as workspace?

@Tyriar yes, that is my thinking as well

@bpasero so is the plan to tweak the behavior to allow opening folders via DND with Electron 1.7.*? Do you need any help with that?

@Tyriar I'd expect a similar behavior to Sublime Text: Folder dragged into Explorer: Add to workspace. Folder dragged into Editor: Open the folder instead. Opening all files is a very bad idea, what if you drag a folder with node_modules ? it'll be hell. Btw, thanks @bpasero for referencing my issue here :)

@darkguy2008 yeah good point, the main thing is squeezing in the "open folder" concept in there somehow as right now that's the only thing that's done (and it will require a full window reload for some time).

@Tyriar I am waiting for Electron to revert the change of Chrome and if that does not happen I need to look into a fix.

Pushed a fix that handles this, differently from before though (we cannot support our old model anymore given the Electron update).

• drop a folder over the editor area will open that folder in the window
• drop a folder over the explorer will add that folder to the workspace if a workspace is opened, otherwise inform the user that you need to open a workspace first (related Allow to drag/drop folder onto multi-root workspace to add folder #31082)

What we gain is the ability to add folders to a workspace by dropping to the explorer, which is cool. What we loose is the visual feedback when you drag that a folder is being dragged. You are now under the impression that you can always drop a folder onto the explorer and the editor will show unhelpful feedback when you drop a folder near the edge of an existing editor by indicating a split operation (which does not make much sense for folders).

Verification: ensure that you can open a single folder by dropping it into the editor area (either with editors opened or not).