Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EH debugging: "Restart" results in two debug sessions #32545

Closed
weinand opened this issue Aug 15, 2017 · 5 comments
Closed

EH debugging: "Restart" results in two debug sessions #32545

weinand opened this issue Aug 15, 2017 · 5 comments
Assignees
@isidorn
Labels
bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues important Issue identified as high-priority verified Verification succeeded
Milestone
August 2017

Comments

@weinand
Copy link
Contributor

weinand commented Aug 15, 2017 •
edited

  • VS Code: Insiders with "inspector" based EH debugging
  • OS: all

Pressing the "Restart" button on the debug floating window restarts the EH process just fine but in many cases results in a second debug session which makes the session drop down appear on the debug floating window.

Most likely this is a timing issue: a new session appears before the old session has terminated.

FYI @roblourens
@weinand weinand added bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues labels Aug 15, 2017
@weinand weinand added this to the August 2017 milestone Aug 15, 2017
@roblourens
Copy link
Member

It seems to think that the first process never terminated. I can't tell whether the debug adapter is doing anything wrong. Let me know if you need anything from me. I'm OOF next week.

@weinand
Copy link
Contributor Author

weinand commented Aug 17, 2017

I've seen the same problem (less frequently) with "legacy" EH debugging, so I don't think this is a specific "inspector" problem. Most likely this is a timing issue: the "inspector" debugger is faster and hits the problem more often. I will investigate...

@weinand weinand removed their assignment Aug 22, 2017
@weinand weinand added the important Issue identified as high-priority label Aug 22, 2017
@weinand weinand mentioned this issue Aug 29, 2017
Closed
@weinand
Copy link
Contributor Author

weinand commented Aug 29, 2017

I'm seeing this issue on Windows too when testing #33305

@isidorn
Copy link
Contributor

isidorn commented Aug 30, 2017

Verifier please verify this works fine now both on osx and windows.

@isidorn
Copy link
Contributor

isidorn commented Aug 30, 2017

Created related #33507

@weinand weinand added the verified Verification succeeded label Sep 1, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@isidorn isidorn

Labels
bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues important Issue identified as high-priority verified Verification succeeded
Projects
None yet
Milestone
August 2017
Development

No branches or pull requests
3 participants
@roblourens @weinand @isidorn