Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keybinding text is not upadated on the menu #32574

Closed
xc1427 opened this issue Aug 15, 2017 · 2 comments
Closed

Keybinding text is not upadated on the menu #32574

xc1427 opened this issue Aug 15, 2017 · 2 comments
Assignees
@bpasero
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone
August 2017

Comments

@xc1427
Copy link

xc1427 commented Aug 15, 2017 •
edited

  • VSCode Version: 1.15.0
  • OS Version: MacOS 10.12.6

Steps to Reproduce:

  1. Install a key remapping plugin such as IntelliJ IDEA Key Bindings for Visual Studio Code or VSmacs
  2. Close all the tabs and windows

screen shot 2017-08-15 at 23 21 09

  1. Quit then re-open VScode
  2. Keys are actually remapped but the keybinding text remains unchanged on menu.

screen shot 2017-08-15 at 23 25 57

This bug should be reproduced with plugin installed. I suppose keybinding text is not properly loaded if nothing is opened, since it displays correctly if at least one tab is opened the last run.
@bpasero bpasero added info-needed Issue requires more information from poster *not-reproducible Issue cannot be reproduced by VS Code Team member as described labels Aug 16, 2017
@bpasero bpasero self-assigned this Aug 16, 2017
@bpasero bpasero added this to the Backlog milestone Aug 16, 2017
@bpasero
Copy link
Member

bpasero commented Aug 16, 2017

@xc1427
Please see if you can find any logged output that could help us find the source of the issue:

  • run code --verbose from the command line and attach the output
  • in Code select Help | Toggle Developer Tools and select the Console
  • attach any output you see in the Console you can find

Thanks!

@bpasero bpasero removed the *not-reproducible Issue cannot be reproduced by VS Code Team member as described label Aug 16, 2017
@bpasero bpasero modified the milestones: August 2017, Backlog Aug 16, 2017
@bpasero bpasero added bug Issue identified by VS Code Team member as probable bug and removed info-needed Issue requires more information from poster new release labels Aug 16, 2017
@bpasero
Copy link
Member

bpasero commented Aug 16, 2017

I think the issue here is that when we resolve keybindings on startup (or window reload) we actually do not wait for the extensions to be ready. But since extensions can have an impact on the keybindings, we need to wait for this event to happen.

I pushed a fix for the keybindings resolver call to wait for onExtensionsReady. That should take care of the issue.

@roblourens roblourens added the verified Verification succeeded label Aug 31, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bpasero bpasero

Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Milestone
August 2017
Development

No branches or pull requests
3 participants
@roblourens @bpasero @xc1427