Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Terminal should force selection on Windows/Linux with shift key #32725

Closed
Tyriar opened this issue Aug 17, 2017 · 2 comments
Closed

Terminal should force selection on Windows/Linux with shift key #32725

Tyriar opened this issue Aug 17, 2017 · 2 comments
Assignees
@Tyriar
Labels
feature-request Request for new features or functionality terminal Integrated terminal issues verification-needed Verification of issue is requested verified Verification succeeded
Milestone
August 2017

Comments

@Tyriar
Copy link
Member

Tyriar commented Aug 17, 2017

Upstream issue: xtermjs/xterm.js#869

Please verify this on Linux by opening tmux in mouse mode and ensuring regular mouse selection triggers "tmux selection" and shift+mouse selection triggers the regular terminal selection.
@Tyriar Tyriar added feature-request Request for new features or functionality terminal Integrated terminal issues labels Aug 17, 2017
@Tyriar Tyriar added this to the August 2017 milestone Aug 17, 2017
@Tyriar Tyriar self-assigned this Aug 17, 2017
Tyriar added a commit that referenced this issue Aug 18, 2017
@Tyriar
Adapt the terminal for xterm v3
84c7d30 
Fixes #32725
Fixes #32552
@Tyriar Tyriar closed this as completed in eee02ec Aug 19, 2017
@Tyriar Tyriar added the verification-needed Verification of issue is requested label Aug 28, 2017
@roblourens
Copy link
Member

I thought I verified this last month?

@Tyriar
Copy link
Member Author

Tyriar commented Aug 30, 2017

@roblourens this was Mac only last month, needs verification on Linux.

@roblourens roblourens added the verified Verification succeeded label Aug 30, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

Labels
feature-request Request for new features or functionality terminal Integrated terminal issues verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Milestone
August 2017
Development

No branches or pull requests
2 participants
@roblourens @Tyriar