Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor highlighting bug in JS/TS template strings #32773

Closed
tarekis opened this issue Aug 18, 2017 · 6 comments
Closed

Minor highlighting bug in JS/TS template strings #32773

tarekis opened this issue Aug 18, 2017 · 6 comments
Assignees
@mjbvz
Labels
bug Issue identified by VS Code Team member as probable bug grammar Syntax highlighting grammar javascript JavaScript support issues themes Color theme issues typescript Typescript support issues verified Verification succeeded
Milestone
September 2017

Comments

@tarekis
Copy link

tarekis commented Aug 18, 2017 •
edited

  • VSCode Version: 1.14.2
  • OS Version: Ubuntu 16.04 x64

Dot notations and similar special characters used in code (brackets, commas) inside template strings are highlighted with the string highlighting color instead of proper highlighting color.

Code inside template strings:
selection_034
selection_035

Code outside template strings:
selection_036

Reproduces without extensions: Yes
@mjbvz mjbvz self-assigned this Aug 18, 2017
@mjbvz mjbvz added grammar Syntax highlighting grammar themes Color theme issues bug Issue identified by VS Code Team member as probable bug labels Aug 18, 2017
@mjbvz mjbvz added this to the August 2017 milestone Aug 18, 2017
@mjbvz mjbvz closed this as completed in 74fde6b Aug 18, 2017
@mjbvz
Copy link
Contributor

mjbvz commented Aug 18, 2017

I believe the root cause is that we failed to reset colorization for template expressions in jsx and tsx files. Please try out the next insiders build fixes this issue

@mjbvz mjbvz added javascript JavaScript support issues typescript Typescript support issues labels Aug 18, 2017
@roblourens
Copy link
Member

I still see a difference in some themes. This is "Red":

image

"string" is applied:
image

@roblourens roblourens reopened this Aug 31, 2017
@roblourens
Copy link
Member

How people use that theme, I will never understand.

@mjbvz
Copy link
Contributor

mjbvz commented Aug 31, 2017

Yes, the solution requires a per-theme fix. I only covered vsdark and vslight this iteration. Will investigate doing the same for our other built-in themes next iteration

@mjbvz mjbvz modified the milestones: September 2017, August 2017 Aug 31, 2017
@roblourens
Copy link
Member

Oh I see. Yeah I see it fixed in those themes.

@mjbvz
Copy link
Contributor

mjbvz commented Sep 20, 2017

With 33ec299, this should now be fixed for all built-in themes

@mjbvz mjbvz closed this as completed Sep 20, 2017
@ramya-rao-a ramya-rao-a added the verified Verification succeeded label Sep 27, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mjbvz mjbvz

Labels
bug Issue identified by VS Code Team member as probable bug grammar Syntax highlighting grammar javascript JavaScript support issues themes Color theme issues typescript Typescript support issues verified Verification succeeded
Projects
None yet
Milestone
September 2017
Development

No branches or pull requests
4 participants
@roblourens @mjbvz @tarekis @ramya-rao-a