Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terminal breaks badly on window resize #32878

Closed
joaomoreno opened this issue Aug 21, 2017 · 14 comments
Closed

Terminal breaks badly on window resize #32878

joaomoreno opened this issue Aug 21, 2017 · 14 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug freeze-slow-crash-leak VS Code crashing, performance, freeze and memory leak issues terminal Integrated terminal issues verified Verification succeeded
Milestone

Comments

@joaomoreno
Copy link
Member

joaomoreno commented Aug 21, 2017

Ubuntu

  • Open tmux (or any terminal app which takes mouse control)
  • Resize Code's window

image

Didn't see this last week at all, started happening today only, so it's probably due to a change delivered since Friday. I wonder if it's related to the Shift select changes?

@joaomoreno joaomoreno added bug Issue identified by VS Code Team member as probable bug freeze-slow-crash-leak VS Code crashing, performance, freeze and memory leak issues terminal Integrated terminal issues labels Aug 21, 2017
@joaomoreno
Copy link
Member Author

joaomoreno commented Aug 21, 2017

It also looks like tmux is receiving incorrect width and height values. Notice the line duplication here:

image

Or, independent of tmux, look at what I get when I simply run htop:

image

@Tyriar Tyriar added this to the August 2017 milestone Aug 21, 2017
@Tyriar
Copy link
Member

Tyriar commented Aug 21, 2017

Hmm, I can't repro after tmux and resizing both dimensions of the window rapidly. Could you try update to latest and try again? I pushed a massive update to xterm.js yesterday but it didn't appear to be published to the apt repo.

@Tyriar Tyriar added the info-needed Issue requires more information from poster label Aug 21, 2017
@joaomoreno
Copy link
Member Author

joaomoreno commented Aug 21, 2017

Same happens on macOS in 9c5d505. 😢

A simple resize makes it happen.

@joaomoreno
Copy link
Member Author

Running out of master:

  1. Open terminal
  2. htop
  3. Resize terminal

image

@Tyriar
Copy link
Member

Tyriar commented Aug 21, 2017

I can repro on mac 👍

@joaomoreno
Copy link
Member Author

Oh it doesn't repro on today's insiders. 😕

@Tyriar
Copy link
Member

Tyriar commented Aug 22, 2017

😕

Weird, I'll still have a look when I get a chance.

@joaomoreno
Copy link
Member Author

joaomoreno commented Aug 23, 2017

What the. The issue seems to have returned today!

I know @sandy081 hits it too.

@sandy081
Copy link
Member

Yeah, I saw it yesterday and today (after update) I can't reproduce.

@joaomoreno
Copy link
Member Author

joaomoreno commented Aug 25, 2017

@Tyriar Let me know if I can help somehow. This morning it was broken for a while... and somehow it was fixed when I alt-tabbed into it. Once I reloaded, it was broken again. So weird.

I'm forced to go back to an external terminal. 😢

@sandy081
Copy link
Member

I see the issue again in today's insiders. It is random.

@Tyriar
Copy link
Member

Tyriar commented Aug 25, 2017

I spent an hour or 2 on it yesterday and struggled to reproduce.

Something that would help diagnose: If you happen to reproduce it (ideally out of sources), break where it's throwing which is here:

https://github.com/sourcelair/xterm.js/blob/bfdc468d4bc823b242ada286c7e8ecc7978f2b72/src/Renderer.ts#L142-L145

It would be good to see what the following values are:

  • y
  • this._terminal.buffer.ydisp
  • this._terminal.buffer.ybase
  • row
  • this._terminal.buffer.lines.length

@Tyriar
Copy link
Member

Tyriar commented Aug 25, 2017

I think I found the problem - PR out in xtermjs/xterm.js#923

@Tyriar
Copy link
Member

Tyriar commented Aug 25, 2017

Upstream issue: xtermjs/xterm.js#924

@Tyriar Tyriar closed this as completed in 737d26e Aug 25, 2017
@Tyriar Tyriar removed the info-needed Issue requires more information from poster label Aug 30, 2017
@mjbvz mjbvz added the verified Verification succeeded label Sep 1, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug freeze-slow-crash-leak VS Code crashing, performance, freeze and memory leak issues terminal Integrated terminal issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

4 participants