Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keyboard Focus shifts to body when removing a tree item that has focus #3294

Closed
stevencl opened this issue Feb 23, 2016 · 3 comments
Closed

Keyboard Focus shifts to body when removing a tree item that has focus #3294

stevencl opened this issue Feb 23, 2016 · 3 comments
Assignees
@joaomoreno
Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues tree-widget Tree widget issues
Milestone
May 2017

Comments

@stevencl
Copy link
Member

I used the keyboard to navigate to the add action on the watch expression title in the debug viewlet.

I entered an expression, then tabbed to the delete action for that expression. I hit enter. The expression was deleted. I expected focus to move back to the watch expression title so that I could easily add another expression but instead focus was set to the activity bar meaning I had to press tab repeatedly to get focus inside the debug viewlet.

Found while testing #3246
@stevencl stevencl added bug Issue identified by VS Code Team member as probable bug accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues labels Feb 23, 2016
@bpasero bpasero added this to the March 2016 milestone Feb 29, 2016
@bpasero bpasero changed the title After deleting a watch expression, focus shifts outside of debug viewlet Keyboard Focus shifts to body when removing a tree item that has focus Mar 1, 2016
@bpasero
Copy link
Member

bpasero commented Mar 1, 2016

This looks like a general issue when an action results in a tree item to be removed and thus the element with tabindex gets lost and the browser decides to move focus to the body.

@bpasero
Copy link
Member

bpasero commented Mar 2, 2016

@joaomoreno after our discussion, it would be nice if the tree could just move focus to its tree DIV when it detects that a tree item gets removed from the DOM that contains the document.activeElement.

@bpasero bpasero assigned joaomoreno and unassigned bpasero Mar 7, 2016
bpasero added a commit that referenced this issue Mar 9, 2016
@bpasero
Revert "fixes #3294"
1fb8427 
This reverts commit 16a8d1d.
@bpasero bpasero reopened this Mar 9, 2016
@joaomoreno joaomoreno modified the milestones: Backlog, March 2016 Mar 9, 2016
@joaomoreno joaomoreno added the tree-widget Tree widget issues label Apr 26, 2017
@joaomoreno joaomoreno modified the milestones: Backlog, May 2017 May 2, 2017
@joaomoreno
Copy link
Member

Actually this specific issue is now fixed since the action to delete a watch expression isn't there any more.

@bpasero bpasero removed the bug Issue identified by VS Code Team member as probable bug label May 30, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@joaomoreno joaomoreno

Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues tree-widget Tree widget issues
Projects
None yet
Milestone
May 2017
Development

No branches or pull requests
3 participants
@joaomoreno @bpasero @stevencl