Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default target of Configuration API update should be derived from configuration and resource #32949

Closed
sandy081 opened this issue Aug 22, 2017 · 2 comments
Closed

Default target of Configuration API update should be derived from configuration and resource #32949

sandy081 opened this issue Aug 22, 2017 · 2 comments
Assignees
@sandy081
Labels
api config VS Code configuration, set up issues verification-needed Verification of issue is requested verified Verification succeeded
Milestone
August 2017

Comments

@sandy081
Copy link
Member

sandy081 commented Aug 22, 2017 •
edited

To make it easier for extension author using workspace config update api, VS Code should derive the default target (if not provided) from the configuration and resource.

  • If no resource is provided, then target should be Workspace.
  • If configuration is workbench scoped, then target should be Workspace.
  • If configuration is resource scoped and resource is provided then
    -- target is WorkspaceFolder in MR case
    -- target is Workspace otherwise

cc @dbaeumer
@vscodebot vscodebot bot added the api label Aug 22, 2017
@sandy081 sandy081 self-assigned this Aug 22, 2017
@sandy081 sandy081 added the config VS Code configuration, set up issues label Aug 22, 2017
@sandy081 sandy081 added this to the August 2017 milestone Aug 22, 2017
@dbaeumer
Copy link
Member

@sandy081 thanks.

@sandy081 sandy081 added the verification-needed Verification of issue is requested label Aug 30, 2017
@sandy081
Copy link
Member Author

For verifiers, there is already any issue that updating to user configuration is not working - #33440

@roblourens roblourens added the verified Verification succeeded label Aug 30, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sandy081 sandy081

Labels
api config VS Code configuration, set up issues verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Milestone
August 2017
Development

No branches or pull requests
3 participants
@roblourens @dbaeumer @sandy081