Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

code --uninstall-extension is not the inverse of --install-extension #33106

Closed
fabiospampinato opened this issue Aug 24, 2017 · 6 comments
Closed

code --uninstall-extension is not the inverse of --install-extension #33106

fabiospampinato opened this issue Aug 24, 2017 · 6 comments
Assignees
@joaomoreno
Labels
bug Issue identified by VS Code Team member as probable bug extensions Issues concerning extensions verified Verification succeeded
Milestone
November 2017

Comments

@fabiospampinato
Copy link
Contributor

It was surprising to find out that after a:

code --install-extension ~/Desktop/test.vsix

and a restart, executing this:

code --uninstall-extension ~/Desktop/test.vsix

doesn't remove the extension, instead it throws an error:

Error: Extension '/Users/fabio/Desktop/test.vsix' is not installed.
@vscodebot vscodebot bot added the extensions Issues concerning extensions label Aug 24, 2017
@ramya-rao-a
Copy link
Contributor

--install-extension needs source from where the vsix can be accessed and be installed. Give an extension name or path, it will find the vsix in the marketplace, download and install.
Give path to vsix file, it will install the extension using the vsix file

--uninstall-extension has nothing to do with location of the vsix. It takes extension name and uninstalls it.

This is by design.

cc @joaomoreno for more info if I missed anything

@fabiospampinato
Copy link
Contributor Author

Is there a reason why provided the path of the .vsix file it doesn't get the name of the extension from it?

Running code --help displays the following, which seems to imply that both accept the same kind of argument:

  --install-extension <ext>   Installs an extension.
  --uninstall-extension <ext> Uninstalls an extension.

@ramya-rao-a
Copy link
Contributor

I believe the code --help needs an update :)

@joaomoreno joaomoreno added this to the August 2017 milestone Aug 25, 2017
@joaomoreno joaomoreno added the bug Issue identified by VS Code Team member as probable bug label Aug 25, 2017
@fabiospampinato
Copy link
Contributor Author

That's good, but why not making code --uninstall-extension fetch the extension id from the vsix file?

@joaomoreno
Copy link
Member

@fabiospampinato Sure, it would also not hurt... want to submit a PR for that?

@fabiospampinato
Copy link
Contributor Author

Alright, I'll work on it.

@Tyriar Tyriar added the verified Verification succeeded label Aug 30, 2017
This was referenced Sep 7, 2017
Closed
Merged
@joaomoreno joaomoreno modified the milestones: August 2017, November 2017 Nov 10, 2017
@joaomoreno joaomoreno removed the verified Verification succeeded label Nov 10, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2017
@mjbvz mjbvz added the verified Verification succeeded label Dec 6, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@joaomoreno joaomoreno

Labels
bug Issue identified by VS Code Team member as probable bug extensions Issues concerning extensions verified Verification succeeded
Projects
None yet
Milestone
November 2017
Development

No branches or pull requests
5 participants
@joaomoreno @fabiospampinato @Tyriar @mjbvz @ramya-rao-a