Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd+shift+f (Find in Files) should always select the contents of the search field #33108

Closed
michaeljonathanblack opened this issue Aug 24, 2017 · 4 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug search Search widget and operation issues verified Verification succeeded

Comments

@michaeljonathanblack
Copy link

The current behavior is that pressing cmd+shift+f toggles between the editor and the side panel, but this drives me crazy as I need to check my focus before pressing (or not pressing) that combo when doing a lot of hunting around.

The number of times I've accidentally typed my search into a random file instead of the search field is painful. Please make cmd+shift+f always focus the search field, or at least allow for such an option.

This issue was originally closed, here: #22814 (comment)

I'm not certain why this isn't default behavior as it is common in other editors.

Thanks!

@michaeljonathanblack
Copy link
Author

A related issue: It doesn't select-all in the search field when pressing cmd+shift+f if the field is already focused. It can be quite disorienting.

@roblourens
Copy link
Member

roblourens commented Aug 31, 2017

It is possible to always focus the search field with a binding like this:

{
        "key": "shift+cmd+f",
        "command": "workbench.action.findInFiles"
}

I guess it's not the default just because I don't want to change it this late. But

It doesn't select-all in the search field when pressing cmd+shift+f if the field is already focused

that's a bug, will use this issue for it.

@roblourens roblourens changed the title cmd+shift+f (Find in Files) should not focus the editor cmd+shift+f (Find in Files) should always select the contents of the search field Aug 31, 2017
@michaeljonathanblack
Copy link
Author

I'll take the little victory! Thanks Rob.

@jimmy-guo
Copy link

Thank you! Cheers to no more git diff surprises and no extra cmd+a keystrokes :)

@roblourens roblourens added the bug Issue identified by VS Code Team member as probable bug label Aug 31, 2017
@roblourens roblourens added this to the September 2017 milestone Aug 31, 2017
@jrieken jrieken added the verified Verification succeeded label Sep 29, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug search Search widget and operation issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

4 participants