Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azure-account extensions always blocks extension host startup by 300ms #33138

Closed
alexdima opened this issue Aug 25, 2017 · 3 comments
Closed
Assignees
Labels
important Issue identified as high-priority
Milestone

Comments

@alexdima
Copy link
Member

  • open e.g. a folder and close all files
  • run ./scripts/code.sh --performance
  • F1 > Developer: Startup Performance

screen shot 2017-08-25 at 11 46 45

@alexdima alexdima added the important Issue identified as high-priority label Aug 25, 2017
@alexdima alexdima added this to the August 2017 milestone Aug 25, 2017
@alexdima alexdima changed the title azure-account extensions blocks extension host startup by 300ms azure-account extensions always blocks extension host startup by 300ms Aug 25, 2017
@alexdima
Copy link
Member Author

I'd recommend that the activationEvents for this extension be changed to an empty array.

If I understand this correctly, everyone that wants to use the API exported by this extension will have an extension dependency to this extension. That would make this extension activate when the other extensions activate.


I'd also wanna figure out why it takes 400ms to load the code... (even after making it activate on demand) ... that's a whooping large number IMHO.

@chrmarti
Copy link
Contributor

The original thinking was that we should check for an existing login session as early as possible, but I don't think that should still hold now that the extension is built-in. We can activate on one of the commands (or a dependent extension activating). Not sure where the 400ms come from, one guess is the keytar native module taking its time. /cc @chrisdias

@chrmarti
Copy link
Contributor

Fixed with #33422

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
important Issue identified as high-priority
Projects
None yet
Development

No branches or pull requests

2 participants