Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inconsistent font usage on welcome screen #33146

Closed
io8titan opened this issue Aug 25, 2017 · 2 comments
Closed

Inconsistent font usage on welcome screen #33146

io8titan opened this issue Aug 25, 2017 · 2 comments
Assignees
@chrmarti
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone
September 2017

Comments

@io8titan
Copy link

  • VSCode Version: Code - Insiders 1.16.0-insider (b9ac102, 2017-08-25T05:24:57.523Z)
  • OS Version: Windows_NT x64 10.0.15063
  • Extensions:
Extension Author (truncated) Version
python don 0.7.0
PowerShell ms- 1.4.1

(1 theme extensions excluded)

Steps to Reproduce:
##I am using a Taiwanese Windows 10 where the default font is "MS JhengHei" and I also set the following in the registry to set MS JhengHei as default for most of the legacy Windows apps.

[HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\Windows NT\CurrentVersion\GRE_Initialize]
"GUIFont.Facename"="Microsoft JhengHei"
[HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\Windows NT\CurrentVersion\FontSubstitutes]
"MS Shell Dlg 2"="Microsoft JhengHei"
"MS Shell Dlg"="Microsoft JhengHei"

  1. Start with welcome screen
  2. The welcome screen's font for items on the right side is a mixture of the system default font MS Jhenghei which is used in other parts of the UI as well and some Ming serif font which looks out of place.
    Could this be fixed to have a consistent UI?

Reproduces without extensions: Yes

image
@vscodebot vscodebot bot added the insiders label Aug 25, 2017
@Tyriar
Copy link
Member

Tyriar commented Aug 25, 2017

Duplicate #27876

@Tyriar Tyriar closed this as completed Aug 25, 2017
@Tyriar Tyriar added the *duplicate Issue identified as a duplicate of another issue(s) label Aug 25, 2017
@chrmarti
Copy link
Contributor

The default font for buttons wins over the general css font-family rule.

@chrmarti chrmarti reopened this Aug 29, 2017
@chrmarti chrmarti removed the *duplicate Issue identified as a duplicate of another issue(s) label Aug 29, 2017
@chrmarti chrmarti added this to the September 2017 milestone Aug 29, 2017
@chrmarti chrmarti added the bug Issue identified by VS Code Team member as probable bug label Sep 27, 2017
@isidorn isidorn added the verified Verification succeeded label Sep 29, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@chrmarti chrmarti

Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Milestone
September 2017
Development

No branches or pull requests
4 participants
@isidorn @Tyriar @chrmarti @io8titan