Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can't read full InputBox validation error message if it is too long. #33181

Closed
whiskeyjay opened this issue Aug 26, 2017 · 3 comments
Closed

Can't read full InputBox validation error message if it is too long. #33181

whiskeyjay opened this issue Aug 26, 2017 · 3 comments
Assignees
@bpasero
Labels
bug Issue identified by VS Code Team member as probable bug quick-pick Quick-pick widget issues verified Verification succeeded
Milestone
February 2018

Comments

@whiskeyjay
Copy link

image

The message doesn't have a tooltip or any other means to show the full text.
@whiskeyjay whiskeyjay mentioned this issue Aug 26, 2017
Merged
@chrmarti chrmarti assigned jrieken and unassigned chrmarti Aug 29, 2017
@jrieken jrieken assigned bpasero and unassigned jrieken Aug 29, 2017
@bpasero bpasero modified the milestone: August 2017 Aug 30, 2017
@bpasero
Copy link
Member

bpasero commented Aug 30, 2017

We should handle this in a way that the tooltip of the item contains the full message. The validation happens here: https://github.com/Microsoft/vscode/blob/master/src/vs/workbench/browser/parts/quickopen/quickOpenController.ts#L196

@bpasero bpasero added bug Issue identified by VS Code Team member as probable bug help wanted Issues identified as good community contribution opportunities quick-pick Quick-pick widget issues labels Aug 30, 2017
@bpasero bpasero modified the milestones: Backlog, August 2017 Aug 30, 2017
@bpasero bpasero added the good first issue Issues identified as good for first-time contributors label Aug 30, 2017
@anirudhrb
Copy link
Contributor

Is mentoring available for this?

@bpasero bpasero removed help wanted Issues identified as good community contribution opportunities good first issue Issues identified as good for first-time contributors labels Nov 15, 2017
@bpasero bpasero removed this from the Backlog milestone Nov 15, 2017
@bpasero bpasero mentioned this issue Dec 14, 2017
Closed
@whiskeyjay whiskeyjay mentioned this issue Jan 2, 2018
Closed
@bpasero bpasero added this to the February 2018 milestone Feb 6, 2018
@bpasero
Copy link
Member

bpasero commented Feb 6, 2018 •
edited

I added support for the input message and validation to show up in the hover when hovering over the item in the quick pick.

before

@bpasero bpasero closed this as completed Feb 6, 2018
bpasero added a commit that referenced this issue Feb 6, 2018
@bpasero
Can't read full InputBox validation error message if it is too long. (f…
43fb41f 
…ixes #33181)
@jrieken jrieken added the verified Verification succeeded label Feb 28, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Mar 23, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bpasero bpasero

Labels
bug Issue identified by VS Code Team member as probable bug quick-pick Quick-pick widget issues verified Verification succeeded
Projects
None yet
Milestone
February 2018
Development

No branches or pull requests
5 participants
@bpasero @jrieken @anirudhrb @chrmarti @whiskeyjay