Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert extensionHost process.kill fix, once we use Electron with Node 8 #33196

Closed
roblourens opened this issue Aug 26, 2017 · 4 comments
Closed

Revert extensionHost process.kill fix, once we use Electron with Node 8 #33196

roblourens opened this issue Aug 26, 2017 · 4 comments
Assignees
@roblourens @alexdima
Labels
debt Code quality issues debug Debug viewlet, configurations, breakpoints, adapter issues verification-needed Verification of issue is requested verified Verification succeeded
Milestone
September 2018

Comments

@roblourens
Copy link
Member

See #32990

This can probably be reverted, once Electron is using Node 8.
@vscodebot vscodebot bot added the debug Debug viewlet, configurations, breakpoints, adapter issues label Aug 26, 2017
@roblourens roblourens assigned roblourens and unassigned weinand Aug 26, 2017
@roblourens roblourens mentioned this issue Aug 26, 2017
Closed
@roblourens roblourens added the debt Code quality issues label Nov 26, 2017
@alexdima alexdima added this to the June 2018 milestone Jun 12, 2018
@alexdima alexdima self-assigned this Jun 12, 2018
@alexdima
Copy link
Member

Electron 2.0 will be reverted before we ship, so let's postpone this again ...

@alexdima alexdima modified the milestones: June 2018, July 2018 Jun 20, 2018
@alexdima alexdima modified the milestones: July 2018, August 2018 Jul 31, 2018
@alexdima alexdima modified the milestones: August 2018, September 2018 Aug 27, 2018
@roblourens
Copy link
Member Author

FYI @weinand in case we see any EH debug weirdness.

@weinand
Copy link
Contributor

weinand commented Sep 17, 2018

@roblourens thanks for the heads-up.

@bpasero bpasero added the verification-needed Verification of issue is requested label Sep 25, 2018
@isidorn isidorn added the verified Verification succeeded label Sep 26, 2018
@isidorn
Copy link
Contributor

isidorn commented Sep 26, 2018

Verified via code review and that I can no longer repro the original issue #32990

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 1, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@roblourens roblourens

@alexdima alexdima

Labels
debt Code quality issues debug Debug viewlet, configurations, breakpoints, adapter issues verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Milestone
September 2018
Development

No branches or pull requests
5 participants
@roblourens @bpasero @weinand @isidorn @alexdima