Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[shaderlab] Update shaderlab grammar #33316

Closed
Coresi7 opened this issue Aug 29, 2017 · 2 comments
Closed

[shaderlab] Update shaderlab grammar #33316

Coresi7 opened this issue Aug 29, 2017 · 2 comments
Assignees
@aeschli
Labels
feature-request Request for new features or functionality languages-basic Basic language support issues verification-needed Verification of issue is requested verified Verification succeeded
Milestone
September 2017

Comments

@Coresi7
Copy link
Contributor

Coresi7 commented Aug 29, 2017 •
edited

  • VSCode Version: Code 1.15.1 (41abd21, 2017-08-16T18:07:25.676Z)
  • OS Version: Windows_NT x64 10.0.15063
  • Extensions: none

Fixed by #33317
The vscode could not highlight builtin shaderlab matrix for unity builtin.
for example for built-in variable unity_ObjectToWorld (introduced by unity v5.4+)

before

But, the following built-in variable could be highlighted by default (available in Unity before 5.4)
bef

Waiting for fixing...
@Coresi7 Coresi7 mentioned this issue Aug 29, 2017
Closed
@Coresi7 Coresi7 changed the title VSCode does not support Unity 5.4+ built-in matrix variables VSCode does not support Unity 5.4+ built-in matrix variables (fixed by merge request #33317) Aug 29, 2017
@Coresi7 Coresi7 changed the title VSCode does not support Unity 5.4+ built-in matrix variables (fixed by merge request #33317) VSCode does not support Unity 5.4+ built-in matrix variables (fixed by pull request #33317) Aug 29, 2017
@aeschli
Copy link
Contributor

aeschli commented Aug 29, 2017

See my comment in #33317. The fix need to go to https://github.com/tgjones/shaders-tmLanguage.

@aeschli aeschli closed this as completed Aug 29, 2017
@Coresi7 Coresi7 mentioned this issue Aug 29, 2017
Merged
@aeschli aeschli changed the title VSCode does not support Unity 5.4+ built-in matrix variables (fixed by pull request #33317) [shaderlab] Update shaderlab grammar Aug 29, 2017
@aeschli aeschli reopened this Aug 29, 2017
@aeschli aeschli added this to the September 2017 milestone Aug 29, 2017
@Coresi7
Copy link
Contributor Author

Coresi7 commented Aug 30, 2017

Thanks~!
(Fixed by tgjones/shaders-tmLanguage#1 , a grammar update required)

@aeschli aeschli closed this as completed in b47f185 Sep 8, 2017
@aeschli aeschli added languages-basic Basic language support issues feature-request Request for new features or functionality verified Verification succeeded labels Sep 25, 2017
@jrieken jrieken added the verification-needed Verification of issue is requested label Sep 26, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@aeschli aeschli

Labels
feature-request Request for new features or functionality languages-basic Basic language support issues verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Milestone
September 2017
Development

Successfully merging a pull request may close this issue.

Fix #33316 now add support for highlight for Unity 5.4+ built-in matrix variables
4 participants
@jrieken @aeschli @chrmarti @Coresi7