Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explorer: view header comes and goes #33345

Closed
bpasero opened this issue Aug 29, 2017 · 5 comments
Closed

Explorer: view header comes and goes #33345

bpasero opened this issue Aug 29, 2017 · 5 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone

Comments

@bpasero
Copy link
Member

bpasero commented Aug 29, 2017

Steps to Reproduce:

  1. drop a folder into the window to open it
  2. the view header in the explorer comes and goes (this is with opened editors view disabled)

flicker_chrome58

Reproduces without extensions: Yes/No

@sandy081 sandy081 added bug Issue identified by VS Code Team member as probable bug workbench labels Aug 29, 2017
@sandy081 sandy081 added this to the August 2017 milestone Aug 29, 2017
@bpasero bpasero reopened this Aug 31, 2017
@bpasero bpasero added the verification-found Issue verification failed label Aug 31, 2017
@bpasero
Copy link
Member Author

bpasero commented Aug 31, 2017

Still happening with:

  • gitlens installed
  • open editors hidden (via settings)
  • git stash being collapsed in bottom of explorer

@sandy081
Copy link
Member

We have a tricky scenario here git stash view is controlled by context and is made visible after a while.

Assume that git stash view is visible and workbench is refreshed

  • Before extensions are ready, we compute from cache and see there are 2 visible views.
  • After extensions are ready, we see only visible view (git stash view is not visible by context).
  • After a while git lens extension set the context to make git stash view visible.

Hence we see a jump here. Context control views are not in our control, so we cannot avoid the jump.

One proposal I have is, if there are custom views registered in the explorer, then do not show the header in the title even if custom views are hidden. What do you think?

@bpasero
Copy link
Member Author

bpasero commented Aug 31, 2017

One proposal I have is, if there are custom views registered in the explorer, then do not show the header in the title even if custom views are hidden. What do you think?

Does this mean to always show the (more heavy) splitview header for the explorer even when no other view is visible?

@sandy081
Copy link
Member

Yes, only when explorer has custom views registered.

@sandy081
Copy link
Member

After discussing with @bpasero we would leave with this flickering behaviour due to the reason mentioned in comment

@sandy081 sandy081 removed the verification-found Issue verification failed label Aug 31, 2017
@bpasero bpasero added the verified Verification succeeded label Aug 31, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

2 participants