Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preview for tables in markdown files is incorrect #33369

Closed
nehashri opened this issue Aug 29, 2017 · 2 comments
Closed

Preview for tables in markdown files is incorrect #33369

nehashri opened this issue Aug 29, 2017 · 2 comments
Assignees
@mjbvz
Labels
bug Issue identified by VS Code Team member as probable bug markdown Markdown support issues verified Verification succeeded
Milestone
September 2017

Comments

@nehashri
Copy link

  • VSCode Version: Code 1.15.1 (41abd21, 2017-08-16T17:15:57.756Z)
  • OS Version: Darwin x64 16.7.0
  • Extensions:
Extension Author (truncated) Version
vscode-docker Pet 0.0.16
vscode-eslint dba 1.2.11
tslint eg2 0.17.0
Go luk 0.6.63
debugger-for-chrome msj 3.2.0
java red 0.8.0

Markdown preview broken for tables.
Steps to Reproduce:

  1. Create a markdown file with following contents.
    Note: there are 3 spaces before start of table.
Heading
=======
   |Word |Vowel Count|
   |------|----------|
   |Rhythm|0         |
   |Mingle|2         |
  1. The preview for the file does not show the first column in the table.

screen shot 2017-08-29 at 15 37 52

If there are no spaces included before the start of table pipe, the preview of table is rendered correctly.
Whereas if there are spaces, the table rendering is broken. The contents of the first column is pushed to second column.

Reproduces without extensions: Yes
@vscodebot vscodebot bot added new release markdown Markdown support issues labels Aug 29, 2017
@mjbvz mjbvz added this to the September 2017 milestone Aug 29, 2017
@mjbvz mjbvz added the bug Issue identified by VS Code Team member as probable bug label Aug 29, 2017
@mjbvz
Copy link
Contributor

mjbvz commented Aug 29, 2017 •
edited

We use markdown-it, and the table seems to work fine on the current markdown-it demo page: https://markdown-it.github.io I suspect we may just need to bump our markdown-it version

@mjbvz mjbvz closed this as completed in a87c72f Sep 1, 2017
@mjbvz
Copy link
Contributor

mjbvz commented Sep 1, 2017

Should be fixed in first 1.17 insiders:

screen shot 2017-09-01 at 2 40 50 pm

@roblourens roblourens added the verified Verification succeeded label Sep 27, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mjbvz mjbvz

Labels
bug Issue identified by VS Code Team member as probable bug markdown Markdown support issues verified Verification succeeded
Projects
None yet
Milestone
September 2017
Development

No branches or pull requests
3 participants
@roblourens @nehashri @mjbvz