Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initialize size of split views in SCM should be equal #33383

Closed
isidorn opened this issue Aug 29, 2017 · 12 comments
Closed

Initialize size of split views in SCM should be equal #33383

isidorn opened this issue Aug 29, 2017 · 12 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug git GIT issues verified Verification succeeded

Comments

@isidorn
Copy link
Contributor

isidorn commented Aug 29, 2017

#33267

  1. Have a mr workspace with two workspaces each having git support
  2. Notice the inital layout of views in the SCM viewlet is not equal. The second workspace just gets around 20% of space
  3. Doing some changes in the second workspace will leave the split view very small. Due to that I believe they should be the same size to start with. This way it is easier for user to not discover that we support git in a MR environment

screen shot 2017-08-29 at 14 22 47

@isidorn isidorn added bug Issue identified by VS Code Team member as probable bug git GIT issues labels Aug 29, 2017
@joaomoreno
Copy link
Member

joaomoreno commented Aug 29, 2017

I'm pretty sure this isn't true. The initial layout, without any persistence, will always be perfectly split.

There must be something else, investigating. cc @sandy081

@joaomoreno joaomoreno added this to the August 2017 milestone Aug 29, 2017
@joaomoreno
Copy link
Member

joaomoreno commented Aug 29, 2017

Yep steps:

  • Have two repositories open, from two open folders
  • Collapse the second one
  • Remove the second folder from the workspace
  • Add it again

@isidorn This will happen to all views extending from @sandy081 's base class, so explorer, debug, etc.

@sandy081
Copy link
Member

@joaomoreno When you add it back what is the initial size? Guessing there is no initial size and default size was taken

@isidorn
Copy link
Contributor Author

isidorn commented Aug 31, 2017

I still see this in the latest.
Whenver I add a new folder to a workspace it's git view is the minimal size, not equal. I would not expact that -> reopening

git

@isidorn isidorn reopened this Aug 31, 2017
@isidorn isidorn added the verification-found Issue verification failed label Aug 31, 2017
@isidorn
Copy link
Contributor Author

isidorn commented Sep 1, 2017

Sorry but I have to reopen this, it is still not behaving like it should.
Once a split view to git is added the size should be split between them, however the current way random views get minimized (even though they had a good size before a new view is added).

Tried out with latest insiders which contains your fix.

@isidorn isidorn reopened this Sep 1, 2017
jrieken pushed a commit that referenced this issue Sep 1, 2017
jrieken pushed a commit that referenced this issue Sep 1, 2017
@chrmarti
Copy link
Contributor

chrmarti commented Sep 1, 2017

Starting from none and then adding Git repos to subfolders of a single workspace folder still gets out of balance at 3:
image

And then more (never changing the size manually):
image

Reopening for consideration. Not critical for the release from what I see.

@chrmarti chrmarti reopened this Sep 1, 2017
@joaomoreno
Copy link
Member

That's ok.

@isidorn
Copy link
Contributor Author

isidorn commented Sep 4, 2017

  1. code-insiders --user-data-dir SOME_NEW_PATH
  2. Open some folder in code, like vscode, open the git view, close vscode
  3. Start code-insders again as in step 1., add a second folder to your workspace
  4. Notice that the second folder is minimized in the git view

I would expect them to be the same size in 4.

IMHO the issue comes from the fact that when closing vscode in step 2 you remember that the first folder has the maximum size of the pane and that leads to the fact that in 4 it pushed out the second folder.
Not that important, removing milestone

@isidorn isidorn reopened this Sep 4, 2017
@isidorn isidorn removed this from the August 2017 milestone Sep 4, 2017
@joaomoreno joaomoreno added this to the September 2017 milestone Sep 4, 2017
@joaomoreno joaomoreno removed the verification-found Issue verification failed label Sep 4, 2017
@joaomoreno
Copy link
Member

Fixed in master. Initial sizes are now completely different. If you multi select in the provider list, the entire space will be split among all views.

@isidorn
Copy link
Contributor Author

isidorn commented Sep 28, 2017

We no longer use split views for git -> verified

@isidorn isidorn added the verified Verification succeeded label Sep 28, 2017
@sandy081
Copy link
Member

@isidorn I think we use split views for git especially in a Multi root workspace when you select multiple repositories

@isidorn
Copy link
Contributor Author

isidorn commented Sep 29, 2017

@sandy081 thanks for letting me know. Though now whenever I select an additonal repo the space is always evenly split between them -> verified

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug git GIT issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

4 participants