Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Find definition on an item with multiple appears to animate the initial scroll when the peek view is displayed #33416

Closed
Tyriar opened this issue Aug 29, 2017 · 1 comment
Closed

Find definition on an item with multiple appears to animate the initial scroll when the peek view is displayed #33416

Tyriar opened this issue Aug 29, 2017 · 1 comment
Assignees
@alexdima
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone
August 2017

Comments

@Tyriar
Copy link
Member

Tyriar commented Aug 29, 2017

  • VSCode Version: Code - Insiders 1.16.0-insider (d0d00e8, 2017-08-29T06:58:13.897Z)
  • OS Version: Linux x64 4.10.0-32-generic
  • Extensions:
Extension Author (truncated) Version
EditorConfig Edi 0.9.4
lorem-ipsum Tyr 1.0.0
sort-lines Tyr 1.3.0
vscode-svgviewer css 1.4.2
tslint eg2 0.17.0
git-project-manager fel 1.4.0
md-navigate jri 0.0.1
theme-monokai-pro-vscode mon 1.0.1
vscode-scss mrm 0.6.2
seti-icons qin 0.1.3
Ruby reb 0.15.0
vim vsc 0.9.0

(1 theme extensions excluded)

#33299

  1. Open vscode workspace
  2. Open ./node_modules/typescript/lib/lib.d.ts
  3. Scroll up such that AnalyserNode is on the screen (but below the middle)
  4. Ctrl+click AnalyserNode

Observe:

  • AnalyserNode is smooth scrolled to the middle of the editor. This is fine, but not in combination with:
  • The peek view is displayed and its editor does not start on the definition, instead it animates a scroll from some random position.
@vscodebot vscodebot bot added the insiders label Aug 29, 2017
@Tyriar
Copy link
Member Author

Tyriar commented Aug 29, 2017

I notice this problem of the peek view always animating the scroll also applies when finding references in multiple files. For example, when opening a peek view like this:

image

And then navigating with the keyboard. When jumping to a new file, the editor always scrolls. This scroll on a different file gives the impression that it's part of the same file to me.

@alexdima alexdima added editor-smooth bug Issue identified by VS Code Team member as probable bug labels Aug 30, 2017
@alexdima alexdima added this to the August 2017 milestone Aug 30, 2017
jrieken pushed a commit that referenced this issue Sep 1, 2017
@alexdima @jrieken
Fixes #33416: use smooth scrolling when revealing a model reference o…
86f4c96 
…nly when jumping within the same model
@roblourens roblourens added the verified Verification succeeded label Sep 1, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@alexdima alexdima

Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Milestone
August 2017
Development

No branches or pull requests
3 participants
@roblourens @Tyriar @alexdima